QA (public) » openQA Project (public)

https://github.com/os-autoinst/scripts/pull/225 - Fix checking for unknown issues

Still thinking about a way to mock less in order to avoid something like that in the future.

Also, if the grep for "Unknown test issue" fails, the exit code of the whole hook script is 1, which is not what we want. The failing grep is not a fatal error, just an indication hat there is no unreviewed issue. Maybe check for an exit code other than 1 in the label function.

At least we already record the hook_rc code in the minion database, e.g. see https://openqa.opensuse.org/minion/jobs?id=2451893

The ticket I was mentioning is from October 2021 and in "future":
https://progress.opensuse.org/issues/99741

https://github.com/os-autoinst/scripts/pull/226 - Check for expected output of handle_unknown

Also I'm still debugging why the hook script returns 1 in case the output does not contain "Unknown test issue".

While my first fix made the investigation jobs run again, I detected further issues. The output of the clone call changed, and since we expect certain output, that fails, leading to not generating a comment with the list of investigation jobs on the original job.

That's the problem with just running some commands and expect the text output to be the same, instead of using calls with a clearly defined output in JSON for example.

Examples from openqa-investigate:

url=$(echo "$out" | sed -n 's/^Created job.*-> //p')
clone_id=${out/:*/}; clone_id=${clone_id/*#/}

Both do not get the wanted content anymore.

https://github.com/os-autoinst/scripts/pull/228 Adapt to new openqa-clone-job output

https://github.com/os-autoinst/scripts/pull/229 Check if we get passed a job id before investigating

https://github.com/os-autoinst/scripts/pull/230 Fix matching of urls

https://github.com/os-autoinst/scripts/pull/231 Use openqa-clone-job --json-output

That should be the last PR for this issue.

tinita wrote:

I vote for leaving AC2 for #99741

ok

https://github.com/os-autoinst/scripts/pull/231 is merged. https://openqa.opensuse.org/tests?match=:investigate: shows many recent jobs. What I found on OSD is https://openqa.suse.de/tests/11081564#comment-801333 not having a full comment mentioning 1-4 jobs, only "Starting investigation for job 11081564". Can you look into that?

Yes, I now have two tickets about the same problem, see https://progress.opensuse.org/issues/128909#note-10

I created this draft: https://github.com/os-autoinst/openQA/pull/5129 Only output JSON when using --json-output

But I still need to work on the tests