action #128909
closedComments from investigation jobs contain warnings failing to parse SCC_ADDONS setting
Description
lvm+resize_root:investigate:last_good_tests_and_build:52d5f6199bf6996bdb89f3404cf42cc856c8c046+186.1: Use of uninitialized value in split at /usr/share/openqa/script/../lib/OpenQA/Script/CloneJobSUSE.pm line 16. 1 job has been created:
This is specifically:
foreach my $SCC_ADDON (split(/,/, $settings->{'SCC_ADDONS'})) {
The affected test has a _XSCC_ADDONS setting but no SCC_ADDONS.
Updated by livdywan over 1 year ago
- Subject changed from Comments from investigation jobs have warnings that shouldn't be there to Comments from investigation jobs contain warnings failing to parse SCC_ADDONS setting
- Description updated (diff)
Updated by tinita over 1 year ago
- Category set to Regressions/Crashes
- Target version set to Ready
Updated by tinita over 1 year ago
- Status changed from New to In Progress
- Assignee set to tinita
Updated by tinita over 1 year ago
- Status changed from In Progress to Feedback
https://github.com/os-autoinst/scripts/pull/230 Fix matching of urls
Updated by tinita over 1 year ago
- Related to action #128405: Missing investigate jobs on both o3+osd since months? size:M added
Updated by tinita over 1 year ago
I'm wondering why the Use of uninitialized value ended up in stdout, though. The openqa-investigate script only collects output from stdout for the comment content...
Updated by tinita over 1 year ago
PR merged.
Also a more reliable solution which I did for #128405 :
https://github.com/os-autoinst/scripts/pull/231 Use openqa-clone-job --json-output
I could not find out why the warning ended up in the output because we don't redirect stderr to stdout.
Trying to reproduce it on the commandline behaves differently...
Updated by tinita over 1 year ago
- Status changed from Feedback to In Progress
To be clear about the problem:
If I call
out=$(openqa-clone-job --skip-chained-deps ...)
on the commandline, then a warning emitted from the clone script is printed in my terminal and does not end up in out.
The same call inside openqa-investigate, and the warning ends up in out. Which will now lead to errors from jq trying to parse JSON.
Updated by tinita over 1 year ago
Another problem is that if I call openqa-clone-job with --json-output, it still outputs text intended to be read by humans, e.g.
May 08 15:23:49 ariel openqa-gru[10025]: jq (66 /opt/os-autoinst-scripts/openqa-investigate): parse error: Invalid numeric literal at line 1, column 8 (rc: 4 Input: >>>Cloning parents of opensuse-Tumbleweed-DVD-ppc64le-Build20230507-xfstests_nfs4.0-generic@ppc64le
May 08 15:23:49 ariel openqa-gru[10025]: {
May 08 15:23:49 ariel openqa-gru[10025]: "3273075" : 3274318
May 08 15:23:49 ariel openqa-gru[10025]: }<<<)
:(
So maybe I should just delete everything until the first { or [.
Updated by openqa_review over 1 year ago
- Due date set to 2023-05-23
Setting due date based on mean cycle time of SUSE QE Tools
Updated by livdywan over 1 year ago
szarate wrote:
This is specifically:
foreach my $SCC_ADDON (split(/,/, $settings->{'SCC_ADDONS'})) {The affected test has a
_XSCC_ADDONSsetting but noSCC_ADDONS.
As discussed in the Unblock I'll try to confirm what behavior we want here and propose a simple fix which should decouple this ticket from #128405
Another problem is that if I call openqa-clone-job with --json-output, it still outputs text intended to be read by humans, e.g.
which Tina will focus on wrt stderr/stdout handling.
Updated by livdywan over 1 year ago
cdywan wrote:
szarate wrote:
This is specifically:
foreach my $SCC_ADDON (split(/,/, $settings->{'SCC_ADDONS'})) {The affected test has a
_XSCC_ADDONSsetting but noSCC_ADDONS.As discussed in the Unblock I'll try to confirm what behavior we want here and propose a simple fix which should decouple this ticket from #128405
Updated by livdywan over 1 year ago
okurz wrote:
PR from cdywan merged
Ack. Next step before considering this "done" is stderr/stdout handling which Tina's working on i.e. making sure warnings don't leak into comments.
Updated by tinita over 1 year ago
https://github.com/os-autoinst/scripts/pull/232 Capture and output stderr in runcli seperately
Updated by tinita over 1 year ago
- Status changed from Feedback to Resolved
https://github.com/os-autoinst/scripts/pull/232 merged.
I can see stderr separately handled in the gru log now, and the investigation comments are appearing correctly now