action #127280
closedForce_result comment cannot be added on a cancelled child job size:M
Description
I tried to add a force_result comment on a child job (with cancelled status) dependent on another job (with failed status) where a force_result comment had already been added:
https://openqa.suse.de/tests/10826620
Upon submitting the comment, I received an error pop-up saying The comment couldn't be added: Bad Request (screenshot added).
I tried adding a regular comment and subsequently editing it to a force_result pattern. The regular comment could be added fine, but the edit did not go through, with the same error.
I do not have enough data to tell whether this is happening consistently. I had previously been able to add a force_result comment on dependent jobs, but cannot recall whether/how they were child-parent linked.
Files
Updated by okurz over 1 year ago
- Project changed from QA (public) to openQA Project (public)
- Status changed from New to Feedback
- Assignee set to okurz
- Target version set to Ready
I am pretty sure that the force_result comments only work on complete jobs, not jobs that never finished at all
Updated by mkittler over 1 year ago
Steps to reproduce:
- Open https://openqa.suse.de/tests/10826620
- Add comment
label:force_result:softfailed
One only gets the alert as mentioned in the description. The web dev tools reveal a better error message: force_result only allowed on finished jobs
So this is supposedly simply because it is a cancelled job and not a "done" job (and has nothing to do with the child-relation).
Updated by mkittler over 1 year ago
@okurz Ok, so should we allow it for cancelled jobs as well?
I'll improve the error message (so the alert contains the message shown in the dev tools as well). This shouldn't take long.
Updated by vsvecova over 1 year ago
It would be helpful to have a way to ignore cancelled jobs (for the purposes of qam-openqa review) as well, if it's technically possible. When a chained job fails and the linked jobs are cancelled as a result, it doesn't help to add a force_result on the failed job only; the cancelled jobs still block the approval.
Updated by mkittler over 1 year ago
It is definitely technically possible. The question is just whether we want it. When @okurz introduced the feature he explicitly added those checks.
PR for improving the error handling as mentioned: https://github.com/os-autoinst/openQA/pull/5074
Updated by tinita over 1 year ago
- Related to action #101716: Improve error reporting for invalid "force_result" comments added
Updated by okurz over 1 year ago
- Category set to Feature requests
- Status changed from Feedback to New
- Assignee deleted (
okurz) - Priority changed from Normal to Low
- Target version changed from Ready to future
mkittler wrote:
It is definitely technically possible. The question is just whether we want it. When @okurz introduced the feature he explicitly added those checks.
I think I only initially supported finished jobs as that is easier to support and has less implications. I guess by now we can extend to cover not finished jobs as well. One can have big impact with forcing results but now it's in the responsibility of the reviewers and fully traceable so I agree that we should add the support. But not right now due to backlog constraints.
Updated by mkittler over 1 year ago
- Assignee set to mkittler
This has recently come up again twice so I'll take the liberty and have a quick look at it. Presumably it won't take long to implement this.
Updated by mkittler over 1 year ago
- Status changed from New to In Progress
- Target version changed from future to Ready
Updated by livdywan over 1 year ago
- Subject changed from Force_result comment cannot be added on a cancelled child job to Force_result comment cannot be added on a cancelled child job size:M
- Status changed from In Progress to Feedback
Updated by okurz over 1 year ago
- Status changed from Feedback to Resolved
PR merged. Deployed on OSD and effective.