Project

General

Profile

Actions
Copy link

action #124688

open

coordination #96596: [qe-core][CI] CI/CD and Coding style improvements

[qe-core] Reduce execution of compile tests

Added by szarate almost 2 years ago. Updated 4 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
rfan1
Category:
Refactor/Code Improvements
Target version:
QA (public) - QE-Core: Ready
Start date:
2023-02-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
Sprint:
QE-Core: February Sprint 25 (Feb 03 - Feb 28)

Description

In our CI, we have a job that calls the compile target which takes around 9 minutes

export PERL5LIB=../..:os-autoinst:lib:tests/installation:tests/x11:tests/qa_automation:tests/virt_autotest:tests/cpu_bugs:tests/sles4sap/saptune:$PERL5LIB: ; ( git ls-files "*.pm" || find . -name \*.pm|grep -v /os-autoinst/ ) | parallel perl -c 2>&1 | grep -v " OK$" && exit 2; true

And this is looking for all of the files per every PR; if we manage to find a way how to find the files that changed between a PR and what is on master, we can shave a lot of seconds there, and enable it fully after things are merged, as we don't really care about the time there

Files

Screenshot from 2023-03-06 16-04-04.png (92 KB) Screenshot from 2023-03-06 16-04-04.png required workflow rfan1, 2023-03-06 08:10
Actions
Copy link
 #1

Updated by rfan1 almost 2 years ago

  • Status changed from New to Workable
  • Assignee set to rfan1
Actions
Copy link
 #2

Updated by rfan1 almost 2 years ago

Seems we have the code there already:

.PHONY: test-compile
test-compile: check-links
        export PERL5LIB=${PERL5LIB_}:$(shell ./tools/wheel --verify) ; ( git ls-files "*.pm" || find . -name \*.pm|grep -v /os-autoinst/ ) | parallel perl -c 2>&1 | grep -v " OK$$" && exit 2; true

.PHONY: test-compile-changed
test-compile-changed: os-autoinst/
        export PERL5LIB=${PERL5LIB_}:$(shell ./tools/wheel --verify) ; for f in `git diff --name-only | grep '.pm'` ; do perl -c $$f 2>&1 | grep -v " OK$$" && exit 2; done ; true
Actions
Copy link
 #3

Updated by rfan1 almost 2 years ago

  • Status changed from Workable to In Progress
Actions
Copy link
 #6

Updated by rfan1 almost 2 years ago

Please refer to the attached file, that compile tests on pull request phase is required one so that I can not skip it.

https://docs.github.com/en/actions/using-workflows/required-workflows

We may need some github owners to change the default workflow.

Actions
Copy link
 #7

Updated by szarate almost 2 years ago

  • Sprint changed from QE-Core: February Sprint (Feb 08 - Mar 08) to QE-Core: March Sprint (Mar 08 - Apr 05)
Actions
Copy link
 #8

Updated by szarate almost 2 years ago

  • Sprint changed from QE-Core: March Sprint (Mar 08 - Apr 05) to QE-Core: April Sprint 23 (Apr 05 - May 03)
Actions
Copy link
 #9

Updated by rfan1 over 1 year ago

  • Status changed from In Progress to Blocked
Actions
Copy link
 #10

Updated by slo-gin 9 months ago

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

Actions
Copy link
 #11

Updated by mgrifalconi 4 days ago

  • Status changed from Blocked to Rejected
Actions
Copy link
 #12

Updated by okurz 4 days ago

  • Status changed from Rejected to New

@mgrifalconi why did you reject this? As visible in https://github.com/os-autoinst/os-autoinst-distri-opensuse/actions/runs/13137245766 the compile time has not improved at all

Actions
Copy link
 #13

Updated by mgrifalconi 4 days ago

  • Sprint changed from QE-Core: April Sprint 23 (Apr 05 - May 03) to QE-Core: February Sprint 25 (Feb 03 - Feb 28)
  • Tags deleted (qe-core-february-sprint, qe-core-march-sprint)
  • Status changed from New to Feedback

Hey @okurz , thanks for confirming your interest in this! Was in the process to cleanup topics that seemed to have lost interest, since I saw there was a way forward (change stuff in github) but no one took action in the last couple of years.
Will have a look at it with Richard in the next days.

Actions
Copy link

Also available in: Atom PDF