Project

General

Profile

Actions

action #124029

closed

Bugrefs may be picked up even in clarifying comments and there's no clear way to tell if they will be

Added by livdywan over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Observation

When #122302#note-10 was re-opened because the ticket was referenced in a job, I deleted the comment referencing the bug and instead added This is not related to poo#122302. A helpful comment on the ticket suggests it may not work as I was hoping. It's impossible to tell from the web UI if that is or isn't the case, and requires an educated guess based on source code analysis.

Acceptance Criteria

  • AC1: It's clear if and when bugrefs are picked up from comments

Suggestions

  • Verify and understand the actual logic in place e.g. by reading lib/OpenQA/Utils.pm and lib/OpenQA/Schema/Result/Jobs.pm
  • Extend existing unit tests in t/ui/15-comments.t to assert the most desirable behavior
  • Improve the logic to avoid treating something like This is not related to poo#122302 as a bugref, or find some other way to clearly remove the link
  • Look at the existing proof of concept to try and visually show what was actually detected (note that it doesn't work correctly)

Related issues 3 (0 open3 closed)

Related to openQA Project - action #123724: auto_review not working despite ticket in openQA auto review project size:MResolvedmkittler2023-03-24

Actions
Related to openQA Project - action #104778: Expand ticket references in label description strings to URLsResolvedmkittler2022-01-10

Actions
Copied from openQA Infrastructure - action #122302: Support SD-105827 "PowerPC often fails to boot from network with 'error: time out opening'"Resolvednicksinger2022-12-212023-02-02

Actions
Actions #1

Updated by livdywan over 1 year ago

  • Copied from action #122302: Support SD-105827 "PowerPC often fails to boot from network with 'error: time out opening'" added
Actions #2

Updated by okurz over 1 year ago

  • Target version set to future
Actions #3

Updated by okurz over 1 year ago

  • Related to action #123724: auto_review not working despite ticket in openQA auto review project size:M added
Actions #4

Updated by okurz over 1 year ago

  • Priority changed from Low to Normal
  • Target version changed from future to Ready

We decided that we should look into this ticket before #123724. My suggestion is that

  1. We make sure that links to bugs and progress tickets can be put into labels but are not treated as bugrefs. So users would need to write This is *not* about label:bsc#1234 which will be treated as a label, not a bugref, but still clickable. So we would not change functionality, only change how such references are rendered into clickable links in HTML.
  2. Extend webUI help text including an example for the above

After that we should be able to revert https://github.com/os-autoinst/scripts/pull/155 helping with #123724 but this can also be done in #123724

Actions #5

Updated by mkittler over 1 year ago

  • Assignee set to mkittler
Actions #6

Updated by mkittler over 1 year ago

  • Status changed from New to Feedback
Actions #7

Updated by mkittler over 1 year ago

The PR has been merged. To make it more clear how things work now I updated the documentation as well. Since it wasn't very well written and quite outdated the PR turned out a little bigger than expected: https://github.com/os-autoinst/openQA/pull/5001

Actions #8

Updated by mkittler over 1 year ago

  • Status changed from Feedback to Resolved

The documentation PR has been merged as well so I'll consider the ticket resolved.

Actions #9

Updated by okurz 4 months ago

  • Related to action #104778: Expand ticket references in label description strings to URLs added
Actions

Also available in: Atom PDF