action #123888
closed
[os-autoinst] Clone retry attempts seem to be the wrong way around, retrying when not necessary and vice versa size:M
Added by okurz over 1 year ago.
Updated about 1 year ago.
Category:
Regressions/Crashes
Description
Observation¶
From https://openqa.opensuse.org/tests/3089742/logfile?filename=autoinst-log.txt
[2023-02-02T11:16:59.522322+01:00] [info] [pid:7469] ::: OpenQA::Isotovideo::Utils::clone_git: Cloning git URL 'https://github.com/os-autoinst/os-autoinst-distri-openQA.git'
[2023-02-02T11:16:59.522363+01:00] [info] [pid:7469] ::: OpenQA::Isotovideo::Utils::clone_git: Checking out git refspec/branch 'use_podman_everywhere'
[2023-02-02T11:16:59.997119+01:00] [debug] [pid:7469] Cloning into 'os-autoinst-distri-openQA'...
[2023-02-02T11:16:59.997200+01:00] [debug] [pid:7469] Clone failed, retries left: 1 of 2
[2023-02-02T11:17:04.997519+01:00] [debug] [pid:7469] Skipping to clone 'https://github.com/os-autoinst/os-autoinst-distri-openQA.git'; os-autoinst-distri-openQA already exists
[2023-02-02T11:17:05.008632+01:00] [debug] [pid:7469] git hash in /var/lib/openqa/pool/15/os-autoinst-distri-openQA: 552d068b96cf247e2191c4ee6af16dc8f016a4f8
Acceptance criteria¶
- AC1: Clones are re-tried up to 2 times in case of failures
Suggestions¶
- Review the retry logic in os-autoinst
- Extend unit test coverage
- Related to action #123873: openQA test using wheel repo fails to clone: auto_review:"unable to access.*wheel.*Could not resolve host: github.com":retry added
- Assignee set to jbaier_cz
Cloning into 'os-autoinst-distri-openQA'
creates an empty repository
os-autoinst-distri-openQA already exists
retrying git clone will refuse to use already existing repository
Solution would be to delete it and start over
- Status changed from New to In Progress
It seems I didn't drink enough coffee to read the code properly and I accidentally fixed a completely different bug. As the subject suggests, the problem is in the return codes from the clone_git. It dies on error and returns 1 on success.
- Related to action #123556: os-autoinst git cloning of test case repo can fail with auto_review:"fatal.*unable to access.*Connection timed out":retry size:M added
- Due date set to 2023-02-21
Setting due date based on mean cycle time of SUSE QE Tools
- Subject changed from [os-autoinst] Clone retry attempts seem to be the wrong way around, retrying when not necessary and vice versa to [os-autoinst] Clone retry attempts seem to be the wrong way around, retrying when not necessary and vice versa size:M
- Description updated (diff)
- Status changed from In Progress to Feedback
- Status changed from Feedback to Resolved
It should be OK
[2023-02-09T16:55:39.427567+01:00] [info] [pid:2401] ::: OpenQA::Isotovideo::Utils::clone_git: Cloning git URL 'https://github.com/os-autoinst/os-autoinst-wheel-launcher.git'
[2023-02-09T16:55:39.904224+01:00] [debug] [pid:2401] Cloning into 'os-autoinst-wheel-launcher'...
[2023-02-09T16:55:39.914523+01:00] [debug] [pid:2401] scheduling boot /tests/install/boot.pm
Also available in: Atom
PDF