Project

General

Profile

Actions
Copy link

action #123888

closed

[os-autoinst] Clone retry attempts seem to be the wrong way around, retrying when not necessary and vice versa size:M

Added by okurz almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
High
Assignee:
jbaier_cz
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2023-02-02
Due date:
2023-02-21
% Done:

0%

Estimated time:
Tags:
os-autoinst, reactive work

Description

Observation

From https://openqa.opensuse.org/tests/3089742/logfile?filename=autoinst-log.txt

[2023-02-02T11:16:59.522322+01:00] [info] [pid:7469] ::: OpenQA::Isotovideo::Utils::clone_git: Cloning git URL 'https://github.com/os-autoinst/os-autoinst-distri-openQA.git'
[2023-02-02T11:16:59.522363+01:00] [info] [pid:7469] ::: OpenQA::Isotovideo::Utils::clone_git: Checking out git refspec/branch 'use_podman_everywhere'
[2023-02-02T11:16:59.997119+01:00] [debug] [pid:7469] Cloning into 'os-autoinst-distri-openQA'...

[2023-02-02T11:16:59.997200+01:00] [debug] [pid:7469] Clone failed, retries left: 1 of 2
[2023-02-02T11:17:04.997519+01:00] [debug] [pid:7469] Skipping to clone 'https://github.com/os-autoinst/os-autoinst-distri-openQA.git'; os-autoinst-distri-openQA already exists
[2023-02-02T11:17:05.008632+01:00] [debug] [pid:7469] git hash in /var/lib/openqa/pool/15/os-autoinst-distri-openQA: 552d068b96cf247e2191c4ee6af16dc8f016a4f8

Acceptance criteria

  • AC1: Clones are re-tried up to 2 times in case of failures

Suggestions

  • Review the retry logic in os-autoinst
  • Extend unit test coverage

Related issues 2 (0 open — 2 closed)

Related to openQA Project (public) - action #123873: openQA test using wheel repo fails to clone: auto_review:"unable to access.*wheel.*Could not resolve host: github.com":retryResolvedjbaier_cz2023-02-01

Actions
Related to openQA Project (public) - action #123556: os-autoinst git cloning of test case repo can fail with auto_review:"fatal.*unable to access.*Connection timed out":retry size:MResolvedjbaier_cz2023-01-23

Actions
Actions
Copy link
 #1

Updated by okurz almost 2 years ago

  • Related to action #123873: openQA test using wheel repo fails to clone: auto_review:"unable to access.*wheel.*Could not resolve host: github.com":retry added
Actions
Copy link
 #2

Updated by jbaier_cz almost 2 years ago

  • Assignee set to jbaier_cz

Cloning into 'os-autoinst-distri-openQA'
creates an empty repository

os-autoinst-distri-openQA already exists
retrying git clone will refuse to use already existing repository

Solution would be to delete it and start over

Actions
Copy link
 #4

Updated by jbaier_cz almost 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by jbaier_cz almost 2 years ago

It seems I didn't drink enough coffee to read the code properly and I accidentally fixed a completely different bug. As the subject suggests, the problem is in the return codes from the clone_git. It dies on error and returns 1 on success.

Actions
Copy link
 #7

Updated by jbaier_cz almost 2 years ago

  • Related to action #123556: os-autoinst git cloning of test case repo can fail with auto_review:"fatal.*unable to access.*Connection timed out":retry size:M added
Actions
Copy link
 #8

Updated by openqa_review almost 2 years ago

  • Due date set to 2023-02-21

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #9

Updated by livdywan almost 2 years ago

  • Subject changed from [os-autoinst] Clone retry attempts seem to be the wrong way around, retrying when not necessary and vice versa to [os-autoinst] Clone retry attempts seem to be the wrong way around, retrying when not necessary and vice versa size:M
  • Description updated (diff)
  • Status changed from In Progress to Feedback

Let's improve a bit with https://github.com/os-autoinst/os-autoinst/pull/2258

The branch was merged, so let's see if it works in production

Actions
Copy link
 #10

Updated by jbaier_cz almost 2 years ago

  • Status changed from Feedback to Resolved

It should be OK

[2023-02-09T16:55:39.427567+01:00] [info] [pid:2401] ::: OpenQA::Isotovideo::Utils::clone_git: Cloning git URL 'https://github.com/os-autoinst/os-autoinst-wheel-launcher.git'
[2023-02-09T16:55:39.904224+01:00] [debug] [pid:2401] Cloning into 'os-autoinst-wheel-launcher'...

[2023-02-09T16:55:39.914523+01:00] [debug] [pid:2401] scheduling boot /tests/install/boot.pm
Actions
Copy link

Also available in: Atom PDF