Project

General

Profile

Actions

action #120735

closed

coordination #68794: [qe-core][functional][epic] rework postfail hooks

[qe-core] PoC: Decrease typing on `post_fail_hooks` log collection

Added by szarate over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
Start date:
2022-11-18
Due date:
% Done:

0%

Estimated time:
Difficulty:
Sprint:
QE-Core: March Sprint (Mar 08 - Apr 05)

Description

Right now we have several routines that are doing a lot of typing, and a lot of it could be executed in a single script, (if what has to be typed is longer than 80 characters, os-autoinst will upload one script instead, and execute that), however we could benefit from running scripts directly to collect all the information in a single go, per log level.

While we're at it, we can extract the export_logs_* to Utils::Logging:: or a better namespace, so we can shed some lines from opensusebasetest

  • lib/opensusebasetest.pm:471:sub export_logs_basic {
  • lib/opensusebasetest.pm:504:sub export_logs {
  • lib/opensusebasetest.pm:539:sub export_logs_locale {
  • lib/opensusebasetest.pm:596:sub export_logs_desktop {

Once this is done, we should shave some minutes of typing (see parent ticket) which can be up to 30m

Suggestions

  • Take note on how long do we expend on collecting logs for a single test that fails across different architectures
  • Prepare a proposal with the changes and discuss them with the team

Acceptance Criteria

  1. AC1: Proposal has been created (doesn't need to be merged)
  2. AC2: export_logs* has been extracted to its own module

Related issues 2 (2 open0 closed)

Copied from openQA Tests - action #120720: [qe-core] Use Utils::Logging::save_ulog to redefine upload_logs in opensusebasetestNew2022-11-18

Actions
Copied to openQA Tests - action #120882: [qe-core] ensure `os-autoinst` reports properly the execution time of `post_fail_hooks`Blocked2023-01-19

Actions
Actions

Also available in: Atom PDF