action #120411
closedcoordination #121876: [epic] Handle openQA review failures in Yam squad - SLE 15 SP5
Apply firewall restart after each command that change configuration only in SLE
0%
Description
Motivation¶
In the current build 40.1 we have systemic failures in the test modules introduced in #113492 that all fail in validate_script_output
:
- yast2_firewall_set_default_zone_prepare
- yast2_firewall_set_default_zone
- yast2_firewall_set_service_port
According to https://bugzilla.suse.com/show_bug.cgi?id=1204893 we need to restart the firewall to validate properly the configuration in SLE due to defaults, reload doesn't work (see why in the bug) and that explains why for openSUSE we don't need a restart.
Acceptance criteria¶
AC1: Apply firewall restart after each command that change configuration only in SLE
Additional information¶
https://firewalld.org/documentation/man-pages/firewall-cmd.html (search for FlushAllOnReload
)
For UI testing we always avoid conditions, specially those magic ones is_sle, is_tumbleweed, which just have tendency to accumulate and create spaghetti code. For UI we have different patterns to be use.
On the other hand for validation of the system, packages are different between different products and architectures so it is more tricky to avoid conditions. we could use:
- similar patterns than with UI (too complex, probably it is not worth it)
- test data or TDD (looks weird in cases like this when only one command is different, some command are set in code other in test data... no-go)
- conditional logic:
Probably the best solution, but only if we know exactly to what is conditional and it is not is_sle and derivatives, in this case that particular setting for firewall, so we can express in the code this difference based on that default that change between products, it is clear code, therefore we could:
- check the value of FlushAllOnReload (only one at the beginning of the test).
- restart or not accordingly.
Updated by rainerkoenig almost 2 years ago
Updated by JERiveraMoya almost 2 years ago
- Tags set to qe-yast-refinement
- Description updated (diff)
- Priority changed from Normal to High
- Target version set to Current
Updated by coolgw almost 2 years ago
This is issue of yast, no a ticket for us.
Reload firewall can not take effect.
Updated by JERiveraMoya almost 2 years ago
coolgw wrote:
This is issue of yast, no a ticket for us.
Reload firewall can not take effect.
Let's restart the service then. Updated description.
Updated by JERiveraMoya almost 2 years ago
- Subject changed from Investigate failures in new yast2_firewall* modules using the libyui-rest-api to Apply firewall restart after each command that change configuration only in SLE
- Description updated (diff)
Updated by JERiveraMoya almost 2 years ago
- Tags deleted (
qe-yast-refinement) - Status changed from New to Workable
Updated by tinawang123 almost 2 years ago
- Status changed from Workable to In Progress
Updated by tinawang123 almost 2 years ago
Updated by openqa_review almost 2 years ago
This is an autogenerated message for openQA integration by the openqa_review script:
This bug is still referenced in a failing openQA test: yast2_gui
https://openqa.suse.de/tests/10226704#step/yast2_firewall_set_default_zone_prepare/1
To prevent further reminder comments one of the following options should be followed:
- The test scenario is fixed by applying the bug fix to the tested product or the test is adjusted
- The openQA job group is moved to "Released" or "EOL" (End-of-Life)
- The bugref in the openQA scenario is removed or replaced, e.g.
label:wontfix:boo1234
Expect the next reminder at the earliest in 28 days if nothing changes in this ticket.
Updated by JERiveraMoya almost 2 years ago
- Status changed from In Progress to Resolved