Project

General

Profile

action #120411

Updated by JERiveraMoya over 1 year ago

#### Motivation 
 In the current build 40.1 we have systemic failures in the test modules introduced in #113492 that all fail in `validate_script_output`: 

 * [yast2_firewall_set_default_zone_prepare](https://openqa.suse.de/tests/9920019#step/yast2_firewall_set_default_zone_prepare/16) 
 * [yast2_firewall_set_default_zone](https://openqa.suse.de/tests/9920019#step/yast2_firewall_set_default_zone/14) 
 * [yast2_firewall_set_service_port](https://openqa.suse.de/tests/9920019#step/yast2_firewall_set_service_port/20) 

 According to https://bugzilla.suse.com/show_bug.cgi?id=1204893 https://bugzilla.suse.com/show_bug.cgi?id=1204893#c7 we need to **restart** reload/restart the firewall to validate properly the configuration in SLE due to defaults, reload doesn't work (see why in the bug) and that explains why for openSUSE we don't need a restart. 

 #### Acceptance criteria 
 **AC1**: Apply firewall restart after each command that change configuration 

 #### Additional information 
 https://firewalld.org/documentation/man-pages/firewall-cmd.html (search for `FlushAllOnReload`) 
 As a suggestion, for simplicity, even if we don't want reload/restart where needed to add condition to test, we can do exception here to "arrange" our test data, instead of using test data, so `my %settings` might contain a ternary condition and if it is sle, type fix the firewald restart command, which we concatenate on `validate_script_output(...`. issues 

Back