QA (public) » openQA Project (public) » openQA Tests (public) » qe-yam

Description

when reviewing the openQA job, I find that the needle "bootloader-ofw-12spX-grub2-20221027" has the tags "bootloader" and "grub2", but the process is different with different tag in "boot_local_disk"(bootloader_setup.pm) function, such as:

sub boot_local_disk {                                                                                                         
    if (get_var('OFW')) {                                                                                                     
        # TODO use bootindex to properly boot from disk when first in boot order is cd-rom                                    
        wait_screen_change { send_key 'ret' };                                                                                
        # Currently the bootloader would bounce back to inst-bootmenu screen after pressing 'ret'                             
        # on 'local' menu-item, we have to check it and send 'ret' again to make booting properly                                     
        if (check_screen(['bootloader', 'inst-bootmenu'], 30)) {                                                              
            record_info 'bounce back to inst-bootmenu, send ret again';                                                       
            send_key 'ret';                                                                                                   
        }                                                                                                                     
        my @tags = qw(inst-slof grub2);                                                                                       
        push @tags, 'encrypted-disk-password-prompt' if (get_var('ENCRYPT'));                                                 
        assert_screen(\@tags);
        if (match_has_tag 'grub2') {                                                                                          
            diag 'already in grub2, returning from boot_local_disk';                                                          
            stop_grub_timeout;                                                                                                
            return;                                                                                                           
        }

the code will send "ret" again if the matched needle has "bootloader" or "inst-bootmenu" tag, so the above openQA job failed.

go further, I find that openQA/we are difficult to distinguish the difference between these needles with "bootloader", "grub2" and "inst-bootmenu" tags, such as:

bootloader-ofw-12spX-grub2-20221027  ==> tags: "bootloader", "grub2"
bootloader-ofw-20150724              ==> tags: "bootloader", "inst-menu"
bootmenu-SLE_-textmode-20210706.json ==> tags: "bootloader", "grub2"
bootloader_uefi-20170718             ==> tags: "bootloader-grub2", "inst-bootmenu"

these needles has two tags, and the process is different with the tags in our code, so I think we need to make one needle with one tag, and make clear the definition of "bootloader", "inst-bootmenu", "grub2" and other key tags.

could you have any suggestion about this issue?