openSUSE admin

That config is out there, so you can take a look at it: https://code.opensuse.org/heroes/salt/blob/production/f/pillar/role/web_jekyll.sls it is quite complex, so I presume we are doing something wrong here

I am mostly an nginx newbie, but after doing some research, I made the following change:

# diff -u news.opensuse.org.conf.bkup news.opensuse.org.conf
--- news.opensuse.org.conf.bkup 2022-03-01 12:43:04.503567724 +0000
+++ news.opensuse.org.conf      2022-10-28 08:58:36.865969060 +0000
@@ -28,7 +28,7 @@

     location / {
         index index.html index.htm;
-        try_files $uri $uri/index.html $uri.html;
+        try_files $uri $uri/ $uri.html =404;

     }

     if ($args ~* "feed=rss2") {

Please, could someone, who knows news.o.o and nginx, review the above.

That change looks good to me, indeed it should end with =404

hellcp wrote:

That change looks good to me, indeed it should end with =404

Thanks for reviewing it! Looking at the other sites:

101.opensuse.org
debuginfod.opensuse.org
get.opensuse.org
monitor.opensuse.org
planet.opensuse.org
search.opensuse.org
www.opensuse.org
yast.opensuse.org

they all have the same issue - a url that cannot be found causes a loop, and then a 500.
It would seem to be a Good Idea (R) to apply the same change to all of them? It would mean wasting less resources, and probably also reduced traffic (because e.g. search engines usually give up when they receive a 404).

pjessen wrote:

-        try_files $uri $uri/index.html $uri.html;
+        try_files $uri $uri/ $uri.html =404;

Extending try_files with =404 makes sense, but I'd keep the other values and just append the =404 (unless you have a good reason for removing some values).

BTW: Changing this isn't too much work - if you update the web_static and web_jekyll roles, that will fix lots of our (sub)domains.

cboltz wrote:

pjessen wrote:

-        try_files $uri $uri/index.html $uri.html;
+        try_files $uri $uri/ $uri.html =404;

Extending try_files with =404 makes sense, but I'd keep the other values and just append the =404 (unless you have a good reason for removing some values).

Thanks for reviewing, Christian.
I thought it made sense to change $uri/index.html to $uri/ to use the default index definition?

BTW: Changing this isn't too much work - if you update the web_static and web_jekyll roles, that will fix lots of our (sub)domains.

Hmm, I'll have a look, I guess I have to get used to this salt stuff.