action #119032
closed
- Subject changed from Help with dark mode development to Help with dark mode development size:M
- Description updated (diff)
- Status changed from New to Workable
- Status changed from Workable to In Progress
- Due date set to 2022-11-04
Setting due date based on mean cycle time of SUSE QE Tools
Unfortunately after some research and experimentation i don't see a way to make a theme selector work with the current SCSS files. There is no way to override prefers-color-scheme
from HTML/JavaScript, which means the media queries cannot be influenced. So we will have to find a way that does not involve inline media queries.
Marius had the idea to replace the media queries with a .darkmode
class, which is then conditionally applied to the <body>
element. That makes forced light/dark mode very easy, and with the Window.matchMedia()
API it should also work for detection. Personally i would prefer a separate darkmode CSS file with overrides for the base light mode CSS file. But we don't know yet if all the darkmode settings would work that way. So i'll first explore the .darkmode
class solution.
- Status changed from In Progress to Resolved
- Status changed from Resolved to Feedback
- Priority changed from Normal to High
This is not the right ticket to collect bugs in the new dark mode theme though. Please make new ones for that, otherwise it would go on forever, since there are a lot of bugs. :)
- Related to action #119362: [darkmode] Test overview table header is broken added
- Related to action #119365: [darkmode] Some form buttons are invisible by default added
- Related to action #119371: [darkmode] Search results are bright white added
- Related to action #119374: [darkmode] Various tables have broken borders added
I think darkmode is in a usable state again now.
- Related to action #119386: [darkmode] Some large pages show up with light theme briefly before switching to dark theme added
- Status changed from Feedback to Resolved
- Parent task set to #128429
- Parent task changed from #128429 to #128435
- Due date deleted (
2022-11-04)
Also available in: Atom
PDF