Project

General

Profile

action #117622

[qe-core] Unable to clone Git repository for wheels

Added by mgrifalconi 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Bugs in existing tests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

https://openqa.suse.de/tests/9668977#

[2022-10-06T02:01:46.761898+02:00] [info] ::: OpenQA::Isotovideo::Utils::checkout_git_repo_and_branch: Cloning git URL 'https://github.com/Zaoliang/functional_wheel'
[2022-10-06T02:01:52.973889+02:00] [debug] Cloning into 'functional_wheel'...
   fatal: unable to access 'https://github.com/Zaoliang/functional_wheel/': OpenSSL SSL_connect: Connection reset by peer in connection to github.com:443 

Regardless of the cause of the issue, I am against using personal repos for test. What happens if owner changes team or company or simply on vacation?
It's great for trying things out but when using on production, it should go into company owned github accounts, and squad owned repos.

Acceptance Criteria

  1. #os-autoinst/os-autoinst-distri-opensuse/15336 is reverted (this removes the urgency of this ticket)
  2. Fork https://github.com/Zaoliang/functional_wheel into https://github.com/os-autoinst/test-core-modules cleanning up unnecesary files (i.e only lib/**.pm should stay)

Related issues

Copied to openQA Project - coordination #117673: [epic][tools] sporadic "Unable to clone Git repository" for wheelsNew2022-10-13

History

#1 Updated by MDoucha 2 months ago

  • Category set to Infrastructure

The current handling of "wheels" is causing random test failures:
https://openqa.suse.de/tests/9650974
https://openqa.suse.de/tests/9650982
https://openqa.suse.de/tests/9668766

Wheels should not cause failures of tests which do not use them, such as the kernel jobs I've linked above. External repository handling needs to be redesigned, preferably to only load wheels when the job explicitly asks for it.

#2 Updated by szarate 2 months ago

  • Copied to coordination #117673: [epic][tools] sporadic "Unable to clone Git repository" for wheels added

#3 Updated by szarate 2 months ago

  • Project changed from openQA Tests to openQA Project
  • Description updated (diff)
  • Category deleted (Infrastructure)
  • Status changed from New to Workable
  • Priority changed from High to Urgent

I think it's better to move the content from the wheels to the test repository, the experiment works and is something we can rely on, but only once #117673 is solved

So having the save_ulog moved back into Utils::Logging is the correct fix for the time being, and eventually we'll look again for other solutions.

We also need to watch the AC, when comming up with things like this, specially

It's great for trying things out but when using on production, it should go into company owned github accounts

I would leave squad owned repos out of the conversation, as these can also change in the future.

External repository handling needs to be redesigned

Indeed, also our approach to using these too.

#4 Updated by szarate 2 months ago

  • Subject changed from [qe-core] Unable to clone Git repository to [qe-core] Unable to clone Git repository for wheels
  • Description updated (diff)

#5 Updated by szarate 2 months ago

  • Project changed from openQA Project to openQA Tests
  • Category set to Bugs in existing tests
  • Target version set to QE-Core: Ready

#6 Updated by slo-gin about 2 months ago

This ticket was set to Urgent priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

#7 Updated by szarate about 2 months ago

  • Sprint set to QE-Core: October Sprint (Sep 28 - Oct 26)

Adding to this sprint (idk how did I miss it)

#8 Updated by zluo about 2 months ago

  • Status changed from Workable to In Progress
  • Assignee set to zluo
  • Priority changed from Urgent to High

take over

#9 Updated by zluo about 2 months ago

revert #15336 at first, but replace old Logging.pm by Logging.pm from wheel repository.

#11 Updated by szarate about 2 months ago

zluo wrote:

revert #15336 at first, but replace old Logging.pm by Logging.pm from wheel repository.

No changes need to be synced, except the documentation of the save_ulog call that needs a bit of love.

#13 Updated by zluo about 2 months ago

szarate to fork a repo into a new repo 'https://github.com/os-autoinst/test-core-modules' I need a qe-core-squad owned account, right? Please advise, thanks!

#14 Updated by zluo about 2 months ago

after discussion with szarate, we don't use external wheel repository from now. I can set it as resolved, however I fixed a minor issue in Logging.pm:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15737

#15 Updated by zluo about 2 months ago

  • Status changed from In Progress to Resolved

PR merged as well.

Also available in: Atom PDF