Project

General

Profile

Actions

action #116788

closed

Cloning of job with released test issues not working

Added by ph03nix about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Start date:
2022-09-19
Due date:
% Done:

0%

Estimated time:

Description

Observation

I can't clone an old job with already released test issues, also if I set the corresponding variable manually.

Steps to reproduce

phoenix@duck-norris:~> openqa-clone-job https://openqa.suse.de/tests/9392017 BASE_TEST_ISSUES= INCIDENT_ID=
Current job 9392017 will fail, because the repositories for the below updates are unavailable
[
  "http://download.suse.de/ibs/SUSE:/Maintenance:/25519/SUSE_Updates_SLE-Module-Basesystem_15-SP4_x86_64",
] at /usr/share/openqa/script/../lib/OpenQA/Script/CloneJobSUSE.pm line 37.

Impact

We can't clone older jobs, even if we would overwrite the incident list manually.

Problem

We can't clone older jobs, even if we would overwrite the incident list manually.

Suggestion

  • Suggestion 1: Consider manual settings in the test issue "lifeness" test
  • Suggestion 2: Provide a new flag which disables this check and point the user to the flag in cause of failure
phoenix@duck-norris:~> openqa-clone-job https://openqa.suse.de/tests/9392017 BASE_TEST_ISSUES= INCIDENT_ID=
Current job 9392017 will fail, because the repositories for the below updates are unavailable. Use the --ignore-missing flag to override
[
  "http://download.suse.de/ibs/SUSE:/Maintenance:/25519/SUSE_Updates_SLE-Module-Basesystem_15-SP4_x86_64",
] at /usr/share/openqa/script/../lib/OpenQA/Script/CloneJobSUSE.pm line 37.

Workaround

sudo vim /usr/share/openqa/script/../lib/OpenQA/Script/CloneJobSUSE.pm

sub detect_maintenance_update ($jobid, $url_handler, $settings) {
    my $urls = collect_incident_repos($url_handler, $settings);
#    die "Current job $jobid will fail, because the repositories for the below updates are unavailable\n" . pp($urls)
#      if @$urls;
}

Related issues 1 (0 open1 closed)

Related to openQA Tests (public) - action #109707: [qe-core] Detect when a maintenance update has been already released before running the testResolveddvenkatachala2022-06-09

Actions
Actions #1

Updated by okurz about 2 years ago

  • Related to action #109707: [qe-core] Detect when a maintenance update has been already released before running the test added
Actions #2

Updated by okurz about 2 years ago

  • Category set to Feature requests
  • Target version set to future

That exact behaviour was added in https://github.com/os-autoinst/openQA/pull/4693 as part of the work on #109707 so "working as designed". But I thought it would be possible to explicitly remove the problematic incident from the list and continue with the others. I would be ok with both suggestion 1 and suggestion 2 but we should clarify with dvenkatachala and szarate who worked on this in before. Added both dvenkatachala and szarate to the "Watchers" list to discuss this with you.

Actions #3

Updated by szarate about 2 years ago

We can't clone older jobs, even if we would overwrite the incident list manually.

This is because the verification is done on the repositories directly, and not the incidents, as the repo list is being generated at the moment of scheduling the tests. Rendering the manual removal of incidents, a noop. Which makes suggestion #2 a no-go.

Question: Why would you like to clone old jobs with already released incidents? perhaps there's a corner case we didn't consider...

Actions #4

Updated by szarate about 2 years ago

Also keep in mind that https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/965fab5f6d2ae78e9f3942f8609f0f08c2c935b4 removed support for manually adding the incidents, and a follow up is pending, to also die when a job is retriggered and the repo doesn't exist (during the test setup)

Actions #5

Updated by ph03nix about 2 years ago

Sorry my bad, the example was wrong. I am setting the INCIDENT_REPO to empty and it still fails. This is unexpected:

openqa-clone-job https://openqa.suse.de/tests/9392017 INCIDENT_REPO=
Current job 9392017 will fail, because the repositories for the below updates are unavailable
[
  "http://download.suse.de/ibs/SUSE:/Maintenance:/25519/SUSE_Updates_SLE-Module-Basesystem_15-SP4_x86_64",
] at /usr/share/openqa/script/../lib/OpenQA/Script/CloneJobSUSE.pm line 37.

I would expect openqa-clone-job to honor manually set *_REPO settings and consider them when doing the liveness test.

Actions #6

Updated by dvenkatachala about 2 years ago

  • Assignee set to dvenkatachala
Actions #7

Updated by dvenkatachala about 2 years ago

  • Status changed from New to In Progress
  • Target version changed from future to QE-Core: Ready
Actions #8

Updated by dvenkatachala about 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF