action #115985
closedFix wrong function used for verifying btrfs quota
0%
Description
Motivation¶
Correct wrong use of the testapi function here
Perl is silently not giving us any clue that we used the wrong test api function.
assert_script_run returns exit code not the command output.
Scope¶
Perhaps this test module is just used under YaST umbrella, but check in other places, openSUSE, etc, just in case.
Acceptance criteria¶
AC1: Use the right function which provide output searching
AC2: If any bugs, report them.
Updated by JERiveraMoya over 2 years ago
- Tags deleted (
qe-yast-refinement) - Status changed from New to Workable
Updated by VANASTASIADIS over 2 years ago
- Status changed from Workable to In Progress
- Assignee set to VANASTASIADIS
Updated by VANASTASIADIS over 2 years ago
- Status changed from In Progress to Resolved
Updated by pvorel over 2 years ago
Thx for fixing, It'd be worth to have way to detect this wrong usage in CI.
Updated by VANASTASIADIS over 2 years ago
Good afternoon @provel, I agree but given that assert_script_run should return the command's exit code, I am not sure rejecting on = assert_script_run would be desirable. I could not find any other instance of storing the return of assert_script_run though.
Updated by pvorel over 2 years ago
I wish there could be a warning if output of assert_script_run() is later used as string which is not a number. But agree, it's probably not possible to test this (at least I have no idea how to test this).