Project

General

Profile

Actions

action #115733

closed

action #97862: More openQA worker hardware for OSD size:M

bot-ng pipeline fails because of empty dictionary in data returned by smelt size:M

Added by livdywan over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
2022-05-23
Due date:
% Done:

0%

Estimated time:

Description

Observation

Traceback (most recent call last):
  File "./qem-bot/bot-ng.py", line 7, in <module>
    main()
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/main.py", line 41, in main
    sys.exit(cfg.func(cfg))
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/args.py", line 41, in do_sync_smelt
    syncer = SMELTSync(args)
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/smeltsync.py", line 19, in __init__
    self.incidents = get_incidents(get_active_incidents())
  File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/loader/smelt.py", line 50, in get_active_incidents
    active.update(x["node"]["incidentId"] for x in incidents["edges"])
TypeError: 'NoneType' object is not subscriptable

See the pipeline logs for details.

Acceptance criteria

  • AC1: A good error message is shown

Suggestions

  • The issue occurred during the maintenance window:
  • Check more carefully what smelt is returning
  • Improve error handling in case of unexpected data e.g. in the easiest case at least handle the exception and show the data that was not parsed correctly
  • Add unit tests covering this type of data

Related issues 1 (0 open1 closed)

Related to QA - action #97955: [openqabot] Possible TypeError during execution "'NoneType' object is not subscriptable"Resolvedjbaier_cz2021-09-02

Actions
Actions #1

Updated by jbaier_cz over 1 year ago

  • Related to action #99489: qa-maintenance/openQABot CI job fails on `TypeError: 'NoneType' object is not subscriptable` added
Actions #2

Updated by jbaier_cz over 1 year ago

  • Related to action #97955: [openqabot] Possible TypeError during execution "'NoneType' object is not subscriptable" added
Actions #3

Updated by jbaier_cz over 1 year ago

  • Related to deleted (action #99489: qa-maintenance/openQABot CI job fails on `TypeError: 'NoneType' object is not subscriptable`)
Actions #4

Updated by jbaier_cz over 1 year ago

Please note, it was scheduled during maintenance window, subsequent run is already OK: https://gitlab.suse.de/qa-maintenance/bot-ng/-/jobs/1112008

Actions #5

Updated by livdywan over 1 year ago

  • Subject changed from bot-ng pipeline fails because of empty dictionary in data returned by smelt to bot-ng pipeline fails because of empty dictionary in data returned by smelt size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #6

Updated by jbaier_cz over 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to jbaier_cz
Actions #7

Updated by jbaier_cz over 1 year ago

  • Status changed from In Progress to Feedback

Let's validate those SMELT responses: https://github.com/openSUSE/qem-bot/pull/67

Actions #8

Updated by jbaier_cz over 1 year ago

  • Status changed from Feedback to Resolved

If we want to also see the new error message, we have to wait at least to Thursday (hopefully not).

Actions

Also available in: Atom PDF