action #115733

Updated by cdywan 5 months ago

## Observation

Traceback (most recent call last):
File "./qem-bot/", line 7, in <module>
File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/", line 41, in main
File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/", line 41, in do_sync_smelt
syncer = SMELTSync(args)
File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/", line 19, in __init__
self.incidents = get_incidents(get_active_incidents())
File "/builds/qa-maintenance/bot-ng/qem-bot/openqabot/loader/", line 50, in get_active_incidents
active.update(x["node"]["incidentId"] for x in incidents["edges"])
TypeError: 'NoneType' object is not subscriptable

See the [pipeline logs]( for details.

## Acceptance criteria
* **AC1:** A good error message is shown

## Suggestions
* The issue occurred during the maintenance window:
- Implement deployment freeze
Research if there was a change in the GitLab pipeline to avoid running the pipeline during the maintenance window (see what smelt is returning
* Check more carefully what smelt is returning
* Improve error handling in case of unexpected data e.g. in the easiest case at least handle the exception and show the data that was not parsed correctly
* Add unit tests covering this type of data