Project

General

Profile

Actions

action #110260

closed

o3 logreports - /var/lib/openqa/share/tests/obs/needles is not a git directory size:M

Added by tinita over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2022-02-03
Due date:
% Done:

0%

Estimated time:

Description

We see the following warnings on o3:

# /var/log/openqa
[2022-04-25T09:17:28.805933Z] [warn] [pid:8752] /var/lib/openqa/share/tests/obs/needles is not a git directory
[2022-04-25T09:45:21.130734Z] [warn] [pid:29759] /var/lib/openqa/share/tests/obs/needles is not a git directory
[2022-04-25T09:51:16.928704Z] [warn] [pid:32010] /var/lib/openqa/share/tests/obs/needles is not a git directory
[2022-04-25T09:59:06.379418Z] [warn] [pid:1890] /var/lib/openqa/share/tests/obs/needles is not a git directory
[2022-04-25T10:05:23.079609Z] [warn] [pid:9221] /var/lib/openqa/share/tests/obs/needles is not a git directory

More context for the last one:

[2022-04-25T10:05:23.021959Z] [info] [pid:9221] Running cmd: git -C /var/lib/openqa/share/tests/obs log --stat --pretty=oneline --abbrev-commit --no-merges dd41ad936f8deb0f38400a26cf2bb6e4ca909e93..4928900e3ff4a75a18bbb5f5e6ddf0ae7992eb5a
[2022-04-25T10:05:23.048900Z] [debug] [pid:9221] b7ff8ae Move ruby tests into a branch specific Makefile
 tests/rspec_webui_tests.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
0f78bed Move installation etc. to a Makefile in the branch
 tests/rspec_webui_tests.pm | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
[2022-04-25T10:05:23.049215Z] [info] [pid:9221] cmd returned 0
[2022-04-25T10:05:23.049622Z] [info] [pid:9221] Running cmd: timeout 20 git -C /var/lib/openqa/share/tests/obs diff --stat dd41ad936f8deb0f38400a26cf2bb6e4ca909e93..4928900e3ff4a75a18bbb5f5e6ddf0ae7992eb5a
[2022-04-25T10:05:23.077203Z] [debug] [pid:9221]  tests/rspec_webui_tests.pm | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
[2022-04-25T10:05:23.077519Z] [info] [pid:9221] cmd returned 0
[2022-04-25T10:05:23.079609Z] [warn] [pid:9221] /var/lib/openqa/share/tests/obs/needles is not a git directory

Reproduced by: https://openqa.opensuse.org/tests/2315662#investigation (DISTRI=obs)

The needles directory is not a git repo on its own, but just a needles/ subdirectory in the distri repo. (I wonder why we haven't seen this log message before.)

Rollback steps

Acceptance criteria

  • AC1: The case is handled instead of resulting in a warning

Suggestions

  • Confirm that the code already works as intended and the warnings may be pointless
  • Maybe this is a warning that can be ignored or handled

Related issues 2 (0 open2 closed)

Copied from openQA Project (public) - action #105924: o3 logreports - Template was modifiedRejectedmkittler2022-02-03

Actions
Copied to openQA Project (public) - action #110389: o3 logreports - fatal: ambiguous argument: unknown revision or path not in the working tree size:MResolvedtinita2022-05-17

Actions
Actions #1

Updated by tinita over 2 years ago

  • Copied from action #105924: o3 logreports - Template was modified added
Actions #2

Updated by tinita over 2 years ago

  • Description updated (diff)
Actions #3

Updated by tinita over 2 years ago

  • Description updated (diff)
Actions #4

Updated by tinita over 2 years ago

  • Description updated (diff)
  • Priority changed from High to Normal
Actions #5

Updated by tinita over 2 years ago

  • Copied to action #110389: o3 logreports - fatal: ambiguous argument: unknown revision or path not in the working tree size:M added
Actions #6

Updated by okurz over 2 years ago

  • Status changed from New to Blocked
  • Assignee set to okurz
Actions #7

Updated by okurz over 2 years ago

  • Tags set to reactive work
  • Status changed from Blocked to New
  • Assignee deleted (okurz)

blockers resolved

Actions #8

Updated by livdywan over 2 years ago

  • Subject changed from o3 logreports - /var/lib/openqa/share/tests/obs/needles is not a git directory to o3 logreports - /var/lib/openqa/share/tests/obs/needles is not a git directory size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #9

Updated by kraih over 2 years ago

  • Assignee set to kraih
Actions #10

Updated by kraih over 2 years ago

  • Status changed from Workable to In Progress
Actions #11

Updated by kraih over 2 years ago

I agree that the warning does look rather pointless. PR opened: https://github.com/os-autoinst/openQA/pull/4680

Actions #12

Updated by kraih over 2 years ago

  • Status changed from In Progress to Feedback
Actions #14

Updated by okurz over 2 years ago

  • Status changed from Feedback to Resolved

merged https://github.com/os-autoinst/openqa-logwarn/pull/39 which removed the monitoring blocklist entry. With that merged as well I guess we should be good.

Actions

Also available in: Atom PDF