Project

General

Profile

Actions

action #108971

closed

[tools][tw][sle] with job setting "RETRY=1" , openQA should not re-trigger passed jobs

Added by rfan1 over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2022-03-25
Due date:
% Done:

0%

Estimated time:

Description

Description

Hello tool team experts, I have 2 jobs with job setting "RETRY=1":

https://openqa.suse.de/tests/8378474
https://openqa.suse.de/tests/8378378

However, I found that even the original job passed, it still tried to re-trigger the job again. seems not expected.

it is mentioned in http://open.qa/docs/

Automatic retries of jobs
You might encounter flaky openQA tests that fail sporadically. While the best way to address flaky test code is of course to fix the test code itself. For example if certain steps rely on external components over network retries within the test modules should be applied. However there can still be cases where you might want openQA to automatically retrigger jobs. This can be achieved by setting the test variable RETRY in the format <retries>[:<description>] to an integer value with the maximum number of retries with an optional, additional description string separated by a colon. For example triggering an openQA job with the variable RETRY=2:bug#42 will retrigger an openQA test on failure up to 2 totalling to up to 3 jobs. Note that the retry jobs are scheduled immediately and will be executed as soon as possible depending on available worker slots. Many factors can change in retries impacting the reproducibility, e.g. the used worker host and instance, any network related content, etc. By default openQA tests do not retry. The optional, additional description string is used only for reference and has no functional impact.

Expect result

Only re-trigger the failed job

Workaround

N/A

Can you please help take a look at this issue?
BR//Richard.

Actions #1

Updated by livdywan over 2 years ago

  • Subject changed from [tools][tw][sle] with job setting "RETRY=1" , openQA should re-trigger the failed job to [tools][tw][sle] with job setting "RETRY=1" , openQA should not re-trigger the passed job
Actions #2

Updated by livdywan over 2 years ago

  • Subject changed from [tools][tw][sle] with job setting "RETRY=1" , openQA should not re-trigger the passed job to [tools][tw][sle] with job setting "RETRY=1" , openQA should not re-trigger passed jobs
Actions #3

Updated by okurz over 2 years ago

  • Category set to Regressions/Crashes
  • Target version set to Ready
Actions #4

Updated by mkittler over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

This PR should help with the investigation: https://github.com/os-autoinst/openQA/pull/4582

Actions #5

Updated by mkittler over 2 years ago

  • Status changed from In Progress to Feedback

I've updated the PR to fix the actual issue and to tackle all issues mentioned in https://github.com/os-autoinst/openQA/pull/4422#pullrequestreview-922883535=.

Actions #6

Updated by mkittler over 2 years ago

The PR has been merged and deployed on OSD since 29.03.22 07:33 CEST. However, no job with a relevant result ran in the scenario so far.

Actions #7

Updated by mkittler over 2 years ago

  • Status changed from Feedback to Resolved

It works now, e.g. https://openqa.suse.de/tests/8437766#comments has not been retried but https://openqa.suse.de/tests/8437776#comments has been retried (and there's a comment about it).

Actions #8

Updated by rfan1 over 2 years ago

Thanks @mkittler for the kindly help!

Actions

Also available in: Atom PDF