Project

General

Profile

Actions
Copy link

action #107749

closed

Send the correct number of keys in send_key_until_needlematch

Added by geor over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
amanzini
Target version:
Current
Start date:
2022-08-22
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)

Description

Motivation

Function send_key_until_needlematch, instead of sending the specified key n times, passed via argument, sends the key n+1 times before failing.
This is an issue for some scenarios, for example if an even number of keypresses is required, as is the case of maximizing and unmaximizing a window, by sending an even number of alt-f10.

Scope

Affects all testsuites that call testapi's send_key_until_needlematch.

Acceptance criteria

ΑC1: Modify send_key_until_needlematch so that key is sent the exact amount of times specified in the argument, before failing.
AC2: Make sure that testsuites that use send_key_until_needlematch are not affected

Suggestion

Change the send_key_until_needlematch so that if (!$counter--) becomes if (!--$counter) so that the assert_screen command is executed when $counter has become 0, not -1.

Subtasks 1 (0 open — 1 closed)

action #115619: Adjust send_key_until_needlematch `$counter` argument in testsuites, to match recent changesResolvedamanzini2022-08-22

Actions
Actions
Copy link

Also available in: Atom PDF