Project

General

Profile

Actions

action #107749

closed

Send the correct number of keys in send_key_until_needlematch

Added by geor about 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2022-08-22
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)

Description

Motivation

Function send_key_until_needlematch, instead of sending the specified key n times, passed via argument, sends the key n+1 times before failing.
This is an issue for some scenarios, for example if an even number of keypresses is required, as is the case of maximizing and unmaximizing a window, by sending an even number of alt-f10.

Scope

Affects all testsuites that call testapi's send_key_until_needlematch.

Acceptance criteria

ΑC1: Modify send_key_until_needlematch so that key is sent the exact amount of times specified in the argument, before failing.
AC2: Make sure that testsuites that use send_key_until_needlematch are not affected

Suggestion

Change the send_key_until_needlematch so that if (!$counter--) becomes if (!--$counter) so that the assert_screen command is executed when $counter has become 0, not -1.


Subtasks 1 (0 open1 closed)

action #115619: Adjust send_key_until_needlematch `$counter` argument in testsuites, to match recent changesResolvedamanzini2022-08-22

Actions
Actions #2

Updated by JERiveraMoya about 2 years ago

  • Tags deleted (qe-yast-refinement)
  • Status changed from New to Workable
Actions #3

Updated by amanzini over 1 year ago

not sure if strictly YAST-related, sounds like a ticket for tools team ?

Actions #4

Updated by okurz over 1 year ago

amanzini wrote:

not sure if strictly YAST-related, sounds like a ticket for tools team ?

"openQA Project"? Yes, "tools team"? No, because likely fixable by others :) Everyone can fix problems in public open source projects and help is appreciated.

Actions #5

Updated by amanzini over 1 year ago

  • Assignee set to amanzini
Actions #6

Updated by amanzini over 1 year ago

okurz wrote:

amanzini wrote:

not sure if strictly YAST-related, sounds like a ticket for tools team ?

"openQA Project"? Yes, "tools team"? No, because likely fixable by others :) Everyone can fix problems in public open source projects and help is appreciated.

Totally right :) I was just wondering if QE-YAST is the appropriate queue for this ticket.
Will get in touch with you because I'm not familiar with publishing and testing modifications to os-autoinst project ;)

Actions #7

Updated by JERiveraMoya over 1 year ago

  • Status changed from Workable to In Progress
Actions #9

Updated by amanzini over 1 year ago

  • Status changed from In Progress to Feedback
Actions #10

Updated by amanzini over 1 year ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF