action #107749
closedSend the correct number of keys in send_key_until_needlematch
Description
Motivation¶
Function send_key_until_needlematch, instead of sending the specified key n times, passed via argument, sends the key n+1 times before failing.
This is an issue for some scenarios, for example if an even number of keypresses is required, as is the case of maximizing and unmaximizing a window, by sending an even number of alt-f10.
Scope¶
Affects all testsuites that call testapi's send_key_until_needlematch.
Acceptance criteria¶
ΑC1: Modify send_key_until_needlematch so that key is sent the exact amount of times specified in the argument, before failing.
AC2: Make sure that testsuites that use send_key_until_needlematch are not affected
Suggestion¶
Change the send_key_until_needlematch so that if (!$counter--) becomes if (!--$counter) so that the assert_screen command is executed when $counter has become 0, not -1.
Updated by JERiveraMoya over 2 years ago
description seems also wrong: https://github.com/os-autoinst/os-autoinst/blob/dfa0cab76ed7b14166870f9dcfcf7ce13dd81ce1/testapi.pm#L1403
s/is not matched/is matched/
Updated by JERiveraMoya over 2 years ago
- Tags deleted (
qe-yast-refinement) - Status changed from New to Workable
Updated by amanzini over 2 years ago
not sure if strictly YAST-related, sounds like a ticket for tools team ?
Updated by okurz over 2 years ago
amanzini wrote:
not sure if strictly YAST-related, sounds like a ticket for tools team ?
"openQA Project"? Yes, "tools team"? No, because likely fixable by others :) Everyone can fix problems in public open source projects and help is appreciated.
Updated by amanzini over 2 years ago
okurz wrote:
amanzini wrote:
not sure if strictly YAST-related, sounds like a ticket for tools team ?
"openQA Project"? Yes, "tools team"? No, because likely fixable by others :) Everyone can fix problems in public open source projects and help is appreciated.
Totally right :) I was just wondering if QE-YAST is the appropriate queue for this ticket.
Will get in touch with you because I'm not familiar with publishing and testing modifications to os-autoinst project ;)
Updated by JERiveraMoya over 2 years ago
- Status changed from Workable to In Progress
Updated by amanzini over 2 years ago
Updated by amanzini about 2 years ago
- Status changed from In Progress to Feedback