Project

General

Profile

Actions
Copy link

action #105157

closed

Needle editor canvas has broken border size:M

Added by favogt almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
livdywan
Category:
Feature requests
Target version:
Ready
Start date:
2022-01-20
Due date:
% Done:

0%

Estimated time:

Description

Observation

As can be seen, the border is correct at the top and left side, but is missing entirely on the right and way too fat at the bottom.

Steps to reproduce

  • Login to openqa.opensuse.org
  • Go to any completed openQA job from the finished jobs on https://openqa.opensuse.org/tests/ , select a screenshot and click the needle pin to open the needle editor
  • Look at the border where the current screenshot touches the white background and confirm that there is overlap on the right and a comparably big border on the bottom

Acceptance criteria

  • AC1: The screenshot display in the needle editor has consistent borders

Suggestions

  • Make it the same pixel width to the right and bottom as on left and top
  • Alternative: Ensure that there is no border
  • Optional: Make it more obvious where the border is, e.g. a dashed line which is unlikely to appear in the screenshot

Files

Screenshot_20220120_135920.png (119 KB) Screenshot_20220120_135920.png favogt, 2022-01-20 12:59
Actions
Copy link
 #1

Updated by okurz almost 3 years ago

  • Category set to Support
  • Status changed from New to Feedback
  • Assignee set to okurz
  • Target version set to Ready

And what is the impact of that?

Actions
Copy link
 #2

Updated by favogt almost 3 years ago

  • Status changed from Feedback to Workable

okurz wrote:

And what is the impact of that?

It looks ugly, and it's not possible to tell where exactly the 1024x768 area is.

Actions
Copy link
 #3

Updated by okurz almost 3 years ago

  • Category changed from Support to Feature requests
  • Status changed from Workable to New
  • Assignee deleted (okurz)
  • Priority changed from Normal to Low

got it.

Actions
Copy link
 #4

Updated by livdywan almost 3 years ago

  • Subject changed from Needle editor canvas has broken border to Needle editor canvas has broken border size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #5

Updated by livdywan over 2 years ago

  • Status changed from Workable to In Progress

There is no border ;-) The easiest option here is really to get rid of the color. There's nothing wrong with the canvas itself as far as I can see https://github.com/os-autoinst/openQA/pull/4516

Actions
Copy link
 #6

Updated by livdywan over 2 years ago

  • Assignee set to livdywan
Actions
Copy link
 #7

Updated by livdywan over 2 years ago

  • Status changed from In Progress to Feedback

cdywan wrote:

There is no border ;-) The easiest option here is really to get rid of the color. There's nothing wrong with the canvas itself as far as I can see https://github.com/os-autoinst/openQA/pull/4516

As revealed during pair debugging, neither border nor padding need to be set here. However the width is required for the margin to center the needle, which you can see on bigger view sizes.

Actions
Copy link
 #8

Updated by livdywan over 2 years ago

  • Status changed from Feedback to Resolved

Confirmed that the OP is also happy with it

Actions
Copy link

Also available in: Atom PDF