action #105157
Needle editor canvas has broken border size:M
Start date:
2022-01-20
Due date:
% Done:
0%
Estimated time:
Difficulty:
Description
Observation¶
As can be seen, the border is correct at the top and left side, but is missing entirely on the right and way too fat at the bottom.
Steps to reproduce¶
- Login to openqa.opensuse.org
- Go to any completed openQA job from the finished jobs on https://openqa.opensuse.org/tests/ , select a screenshot and click the needle pin to open the needle editor
- Look at the border where the current screenshot touches the white background and confirm that there is overlap on the right and a comparably big border on the bottom
Acceptance criteria¶
- AC1: The screenshot display in the needle editor has consistent borders
Suggestions¶
- Make it the same pixel width to the right and bottom as on left and top
- Alternative: Ensure that there is no border
- Optional: Make it more obvious where the border is, e.g. a dashed line which is unlikely to appear in the screenshot
History
Updated by 
Updated by 
Updated by #5
Updated by cdywan 3 months ago
- Status changed from Workable to In Progress
There is no border ;-) The easiest option here is really to get rid of the color. There's nothing wrong with the canvas itself as far as I can see https://github.com/os-autoinst/openQA/pull/4516
#7
Updated by cdywan 2 months ago
- Status changed from In Progress to Feedback
cdywan wrote:
There is no border ;-) The easiest option here is really to get rid of the color. There's nothing wrong with the canvas itself as far as I can see https://github.com/os-autoinst/openQA/pull/4516
As revealed during pair debugging, neither border nor padding need to be set here. However the width is required for the margin to center the needle, which you can see on bigger view sizes.