QA (public) » openQA Project (public) » openQA Tests (public) » Containers and images

I agree with @ybonatakis that validate_btrfs is a host test (testing the docker storage feature).

buildah is unlikely to find any problem on the images other than podman will find. this is because it used by podman underneath. as such it is a test for host IMO and it is more likely to find bugs against the sut rather the images.
For instance all this time we caught one bug[0] and that was related to host, not the images

validate_btrfs tests the docker storage fs feature which likely belongs to the host tests as well. The image has only run btrfs as requirement IIRC

[0] https://bugzilla.suse.com/show_bug.cgi?id=1185143

ybonatakis wrote:

buildah is unlikely to find any problem on the images other than podman will find. this is because it used by podman underneath. as such it is a test for host IMO and it is more likely to find bugs against the sut rather the images.
For instance all this time we caught one bug[0] and that was related to host, not the images

validate_btrfs tests the docker storage fs feature which likely belongs to the host tests as well. The image has only run btrfs as requirement IIRC

[0] https://bugzilla.suse.com/show_bug.cgi?id=1185143

Ok, then decided. Those should be run only in engines_and_tools and use a single container image (e.g. opensuse). I will prepare for it.

I agree!

i have found that jose had created https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13004. however if i am not mistaken this is not what we agreed above. So i am not sure if it is old commit or something but i created https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13021.

ybonatakis wrote:

i have found that jose had created https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13004. however if i am not mistaken this is not what we agreed above. So i am not sure if it is old commit or something but i created https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13021.

yes, it was created before this ticket.

ybonatakis wrote:

Additional fix: i found that engines_and_tools_docker.yaml uses HOST_VERSION variable but it is not set in the test suite. If i am right this was intended to be a container-based variable.

HOST_VERSION is needed specially for Image-Updates because the VERSION variable refers to the Image we are testing, not the Host.

jlausuch wrote:

ybonatakis wrote:

Additional fix: i found that engines_and_tools_docker.yaml uses HOST_VERSION variable but it is not set in the test suite. If i am right this was intended to be a container-based variable.

HOST_VERSION is needed specially for Image-Updates because the VERSION variable refers to the Image we are testing, not the Host.

We are saying the same thing, right? engines_and_tools_docker.yaml is not used on Image-Updates so the yaml is wrong as such

ybonatakis wrote:

jlausuch wrote:

ybonatakis wrote:

Additional fix: i found that engines_and_tools_docker.yaml uses HOST_VERSION variable but it is not set in the test suite. If i am right this was intended to be a container-based variable.

HOST_VERSION is needed specially for Image-Updates because the VERSION variable refers to the Image we are testing, not the Host.

We are saying the same thing, right? engines_and_tools_docker.yaml is not used on Image-Updates so the yaml is wrong as such

Yep, exactly. engines_and_tools only for host container env validation, it shouldn't be enabled for Image-Updates as the host is always the same.

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13055 to adjust the validate_btrfs. it should run against unreleased images in latest group. with release to the rest. @joseph? do i miss something?

ybonatakis wrote:

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13055 to adjust the validate_btrfs. it should run against unreleased images in latest group. with release to the rest. @joseph? do i miss something?

Since now we have 2 groups for latest_host and latest_image, we also split the hosts tests from the image tests for 15-SP4, so validate_btrfs will stay only in latest_host.