QA (public) » openQA Project (public)

I created a bug report: https://github.com/houseabsolute/Devel-Cover-Report-Codecovbash/issues/1

edit: original repo was deleted, I appended the issue log below.
My fork is here: https://github.com/perlpunk/Devel-Cover-Report-Codecovbash

In the meantime https://github.com/houseabsolute/Devel-Cover-Report-Codecovbash/issues/1 is 404. Can you provide an updated link? Maybe you already plan to update the according CPAN and then openSUSE package with the new source repo plus a fix?

As Dave has already deleted the original repo after I forked it, here is the log of the github issue:

@perlpunk

We found that our Coverage reports on codecov.io are sometimes off by 1 or more lines. It starts at lines with # uncoverable statement.
We are using version 0.03

The Devel::Cover HTML report looks fine, but in the codecov.io HTML, the green/red markers move up, so that empty lines are marked as green for example:
https://codecov.io/gh/os-autoinst/openQA/src/master/t/lib/OpenQA/Test/Utils.pm#L652

I looked into the code and found that this is done on purpose:
https://github.com/houseabsolute/Devel-Cover-Report-Codecovbash/blob/master/lib/Devel/Cover/Report/Codecovbash.pm#L93

return if $statement->[0]->uncoverable;
But maybe what was wanted is:

return undef if $statement->[0]->uncoverable;
Because return in list context will just return an empty list, so nothing is pushed into the array at all.

======================================
@autarch

Member
autarch commented 15 hours ago
Thanks for the report.

If you look at the source for this module, you'll see that I just copied this from Devel-Cover-Report-Codecov. I don't actually know what most of this does! I'm happy to accept a patch, but maybe you'd like to take this distro over if you're actually using it. I only created it to test out codecov support for my Azure Pipelines helpers project.

======================================
@perlpunk

Author
perlpunk commented 14 hours ago
Thanks, I would take the module over :)
My CPAN handle: TINITA

======================================
@autarch

Member
autarch commented 14 hours ago
You are now the primary owner. We can also transfer this repo to another owner. I think the easiest way to do that is to add you as an owner of this repo and let you transfer it. Otherwise you'd need to give me admin access to an organization of your choice.

======================================
@perlpunk

Author
perlpunk commented 14 hours ago
Great, thanks.
From my experience, it's enough if I fork it (which I just did), and as soon as you delete your repo (after I made a new release), my fork will be seen as the origin.

======================================
@autarch

Member
autarch commented 14 hours ago
Alright, sounds good. I will delete the repo now.

For verifying my fix, I pushed a branch with a local fixed copy of the module, and the codecov report looks correct now.

Released 0.04 to CPAN: https://metacpan.org/dist/Devel-Cover-Report-Codecovbash

Request for submit to factory: https://build.opensuse.org/request/show/907468

SR accepted, but not yet in https://build.opensuse.org/project/show/devel:openQA:Leap:15.2

https://build.opensuse.org/package/show/devel:openQA:Leap:15.2/perl-Devel-Cover-Report-Codecovbash has it now. There was a PR updating the dependencies but failing in multiple tests

Dependency PR merged: https://github.com/os-autoinst/openQA/pull/4064