action #94991
closedos-autoinst OBS checks fail in t/10-virtio_terminal.t (https://github.com/os-autoinst/os-autoinst/issues/1686), sporadic failure or only in OBS size:S
Description
Observation¶
See https://github.com/os-autoinst/os-autoinst/issues/1686
No reaction on the github issue nor the mention in the pull request that likely caused this issue so trying again with a ticket in progress.o.o then
Acceptance criteria¶
- AC1: test module does not fail consistently in OBS checks
Problem¶
The test originally passed in the pull request that brought in the change in https://github.com/os-autoinst/os-autoinst/runs/2705598035#step:3:530 so either it's a sporadic failure or fails only in OBS
Suggestions¶
- Execute https://github.com/os-autoinst/os-autoinst/blob/master/t/10-virtio_terminal.t locally sometimes to find out if it's a sporadic issue
- We can remove the test module from OBS checks like we do in https://github.com/os-autoinst/os-autoinst/blob/master/dist/rpm/os-autoinst.spec#L155
- If we can't find a good fix revert the original PR for now and ask the original author to help
- Consider excluding the specific test module from OBS checks right now and potentially open a separate ticket about that
Updated by okurz over 3 years ago
- Subject changed from os-autoinst OBS checks fail in t/10-virtio_terminal.t (https://github.com/os-autoinst/os-autoinst/issues/1686) to os-autoinst OBS checks fail in t/10-virtio_terminal.t (https://github.com/os-autoinst/os-autoinst/issues/1686), sporadic failure or only in OBS size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by ilausuch over 3 years ago
I tested locally 6 times the test (last master repository version) and works without problem
> make test TESTS=t/10-virtio_terminal.t
ninja -C build/ test
ninja: Entering directory `build/'
[0/1] Running tests...
Test project /home/openqa/openQA-dev/repos/os-autoinst/build
Start 1: test-installed-files
1/8 Test #1: test-installed-files ............. Passed 0.09 sec
Start 2: test-local-yaml-syntax
2/8 Test #2: test-local-yaml-syntax ........... Passed 0.16 sec
Start 3: test-local-python-style
3/8 Test #3: test-local-python-style .......... Passed 0.31 sec
Start 4: test-local-tidy
4/8 Test #4: test-local-tidy .................. Passed 8.45 sec
Start 5: test-local-shellcheck
5/8 Test #5: test-local-shellcheck ............ Passed 0.09 sec
Start 6: test-local-perl-style
6/8 Test #6: test-local-perl-style ............ Passed 4.72 sec
Start 7: test-doc-testapi-spellchecking
7/8 Test #7: test-doc-testapi-spellchecking ... Passed 0.13 sec
Start 8: test-perl-testsuite
8/8 Test #8: test-perl-testsuite .............. Passed 0.41 sec
100% tests passed, 0 tests failed out of 8
Updated by ilausuch over 3 years ago
- Status changed from Workable to In Progress
- Assignee set to ilausuch
I created this PR https://github.com/os-autoinst/os-autoinst/pull/1709
Updated by ilausuch over 3 years ago
Doing some tests here
https://build.opensuse.org/package/show/home:ilausuch:branches:devel:openQA/os-autoinst
Updated by openqa_review over 3 years ago
- Due date set to 2021-07-20
Setting due date based on mean cycle time of SUSE QE Tools
Updated by livdywan over 3 years ago
- Status changed from In Progress to Resolved
I created this PR https://github.com/os-autoinst/os-autoinst/pull/1709
Confirmed with @ilausuch that the test is not run in OBS anymore and so this can be considered resolved.
Updated by ilausuch over 3 years ago
Regarding to the attempt to solve the problem. I tested https://github.com/os-autoinst/os-autoinst/pull/1710 several times and it finally failed https://build.opensuse.org/package/live_build_log/home:ilausuch:branches:devel:openQA/os-autoinst/openSUSE_Factory_PowerPC/ppc64le so we can forget this suggestion
Updated by cfconrad about 3 years ago
This PR also try to solve this problem: https://github.com/os-autoinst/os-autoinst/pull/1870
Would be nice if someone could also run tests with this code, thx!