Project

General

Profile

Actions
Copy link

action #94904

closed

Replace partitioning and partitioning_finish modules

Added by oorlov almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
JERiveraMoya
Target version:
Current
Start date:
2021-06-29
Due date:
% Done:

0%

Estimated time:

Description

Motivation

There are a lot of test suites where partitioning and partitioning_finish are used, even though they do nothing, just setting shortcuts and pressing "Next". As we are switching to LibyuiClient in installer, we do not need those modules anymore and can replace them with OOP+Libyui implementation.

Scope

Job Groups: YaST, openSUSE Tumbleweed, openSUSE Leap 15.

Task:

  1. Replace combination of partitioning and partitioning_finish modules with accept_proposed_layout;
  2. Optional: Create schedule in case it is not created yet (e.g. on openSUSE). If there are too many of them, please create separate ticket to do so instead, so that this task will not be overcomplicated.
Actions
Copy link
 #1

Updated by JERiveraMoya almost 3 years ago

We already have [accept_proposed_layout](have https://openqa.suse.de/tests/6352177#step/accept_proposed_layout/1)

Actions
Copy link
 #2

Updated by oorlov almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by oorlov almost 3 years ago

JERiveraMoya wrote:

We already have [accept_proposed_layout](have https://openqa.suse.de/tests/6352177#step/accept_proposed_layout/1)

Thanks, Joaquin. I've added this to description.

Actions
Copy link
 #4

Updated by oorlov almost 3 years ago

  • Tags deleted (qa-yast-refinement)
  • Status changed from New to Workable
Actions
Copy link
 #5

Updated by JERiveraMoya almost 3 years ago

  • Status changed from Workable to In Progress
  • Assignee set to JERiveraMoya
Actions
Copy link
 #6

Updated by JERiveraMoya almost 3 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #7

Updated by oorlov almost 3 years ago

  • Target version changed from SLE 15 SP3 to Current
Actions
Copy link
 #8

Updated by dimstar almost 3 years ago

The merged PR seems to be responsible for the new failures seen in
https://openqa.opensuse.org/tests/1849612

Most likely the is_storage_ng change, which is used in
workaround_type_encrypted_passphrase -> is_boot_encrypted()

and there specifically

return 0 if !get_var('FULL_LVM_ENCRYPT') && !is_storage_ng && !is_ppc64le()
  && !(get_var('ENCRYPT_CANCEL_EXISTING') && get_var('ENCRYPT') && is_aarch64());

(with the change to is_storage_ng the return value changed here

Actions
Copy link
 #9

Updated by JERiveraMoya over 2 years ago

  • Status changed from Feedback to Closed
Actions
Copy link

Also available in: Atom PDF