Project

General

Profile

Actions
Copy link

action #94774

closed

bug referral links only point to bugzilla.suse.com, not the specific bug size:M

Added by okurz almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
dheidler
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2021-06-28
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://openqa.suse.de/tests/6338972#comment-357211 says "label:linked Job mentioned in https://bugzilla.suse.com/" whereas it should point to the specific bug. In this case it's https://bugzilla.suse.com/show_bug.cgi?id=1187747

Steps to reproduce

  • From a bug in bugzilla follow a link to an openQA job
  • Find in the comments tab a link to bugzilla

Expected result

  • The message should include the complete bug ID based URL

Suggestions

Actions
Copy link
 #1

Updated by okurz almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by livdywan almost 3 years ago

  • Subject changed from bug referral links only point to bugzilla.suse.com, not the specific bug to bug referral links only point to bugzilla.suse.com, not the specific bug size:M
  • Status changed from New to Workable
  • Assignee set to dheidler
Actions
Copy link
 #3

Updated by dheidler almost 3 years ago

  • Status changed from Workable to In Progress
Actions
Copy link
 #4

Updated by dheidler almost 3 years ago

After looking at the code it seems to be clear that the referer_url is not altered in any way by the openQA code.
It is only checked against a whitelist of hostnames.

So I see two possible options here: Either some users have a privacy extension in their browser that cuts of any path or get parameters from the referer or the referer is correct but the bug was changed somehow before the link was clicked and the URL is the result a POST request which didn't contain any GET parameters.

Either way the easiest solution would be to simply ignore such requests.
The next user who clicks the link might have accessed the bug with the usual GET url that contains all the parameters he might not have a browser extension that strips part of the referer.

Actions
Copy link
 #5

Updated by dheidler almost 3 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #6

Updated by okurz almost 3 years ago

It was me that

dheidler wrote:

After looking at the code it seems to be clear that the referer_url is not altered in any way by the openQA code.
It is only checked against a whitelist of hostnames.

So I see two possible options here: Either some users have a privacy extension in their browser that cuts of any path or get parameters from the referer or the referer is correct but the bug was changed somehow before the link was clicked and the URL is the result a POST request which didn't contain any GET parameters.

Interesting theory. It could be that behaviour changed on the side of bugzilla. It was me who triggered the link on https://openqa.suse.de/tests/6338972#comments . Could you try it out yourself?

The next user who clicks the link might have accessed the bug with the usual GET url that contains all the parameters he might not have a browser extension that strips part of the referer.

Then we would see updated URLs but I am not sure this is ever the case. You can query all openQA comments and look for that though.

Actions
Copy link
 #7

Updated by dheidler almost 3 years ago

okurz wrote:

Then we would see updated URLs but I am not sure this is ever the case. You can query all openQA comments and look for that though.

Only if the useless comments were removed - they still have the label flags and so it would be skipped the next time someone clicked that link.

Actions
Copy link
 #8

Updated by dheidler almost 3 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF