Project

General

Profile

Actions

action #94231

closed

lessons learned from "make needle matching less forgiving"

Added by okurz almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Organisational
Target version:
Start date:
2021-06-18
Due date:
% Done:

0%

Estimated time:

Description

Motivation

Despite multiple months keeping https://github.com/os-autoinst/os-autoinst/pull/1633 open and pinging test maintainers and even test maintainers asking explicitly to have the change deployed, after the change was going live many more people were struggling with the amount of test failures caused by the change.

Suggestions

  • Write to qa-team@suse.de as well for critical changes as well as chat channels
  • Please propose reverts of features (AFAIR no one suggested that and we would have been fine to do that)
  • From ph0enix: deploy on the beginning of the week, "announcement banners", staging area
  • Feature switches or configurable feature: We should have done that here, this was overlooked
  • See https://github.com/os-autoinst/os-autoinst/pull/1633#issuecomment-797467871 we should have needling with lower match ratio lower than default stated as a more explicit suggestion. From Joaquin SUSE QE Tools workshop chat notes: "The ratio is for each area in the needle, the UI doesn't highlight if a needle is created with lower or upper match ratio", so highlight that a needle is created with different match ratio than default?

Further details

The topic was discussed extensively in the SUSE QE Tools workshop 2021-06-18, recording available in https://youtu.be/wERuChD-88Y

Actions #1

Updated by okurz almost 3 years ago

  • Description updated (diff)
Actions #2

Updated by okurz almost 3 years ago

  • Subject changed from fallout from "make needle matching less forgiving" - lessons learned to lessons learned from "make needle matching less forgiving"

For the last point about the needle match ratio I have added a new section in https://progress.opensuse.org/projects/openqatests/wiki/Wiki#consider-a-lower-than-default-match-ratio. We should still make that more prominent in the needle editor itself.

Actions #3

Updated by okurz almost 3 years ago

  • Description updated (diff)
Actions #4

Updated by okurz almost 3 years ago

  • Status changed from New to Resolved
  • Assignee set to okurz

Added practices to https://progress.opensuse.org/projects/qa/wiki/Wiki/diff?utf8=%E2%9C%93&version=229&version_from=228&commit=View+differences . Added idea for better "lower-than-default" match ratio suggestion in #65271#note-65

Actions #5

Updated by okurz almost 3 years ago

As explicitly asked for in our weekly meeting I created an explicit separate ticket for the needle editor thingy #94717

Actions

Also available in: Atom PDF