QA (public) » openQA Project (public)

Observation¶

The POST /job_templates_scheduling route responds with a 204 code if the passed job template is invalid due to referencing a non-existing machine. The job template is then not applied, but the failure is not evident from the HTTP return code. The actual failure is only observable when having access to the log of the webui.

Steps to reproduce¶

• pick an arbitrary machine name that does not exist on your openQA instance
• send the following template via POST /job_templates_scheduling:

defaults:
  x86_64:
    machine: FOOBAR_I_DO_NOT_EXIST
    priority: 50

• openQA responds with 204, but the job template is not applied

Problem¶

The template is verified and because the machine is invalid, it is not applied. However, the result of the verification is not taken into account when responding to the API call.

Suggestion¶

The error is definitely getting logged by openqa, as the log of the webui reveals:

webui_1          | [error] Machine 'FOOBAR_I_DO_NOT_EXIST' is invalid
webui_2          | [error] Machine 'FOOBAR_I_DO_NOT_EXIST' is invalid
webui_1          | [error] Machine 'FOOBAR_I_DO_NOT_EXIST' is invalid
webui_1          | [error] Machine 'FOOBAR_I_DO_NOT_EXIST' is invalid

Workaround¶

Check that the job template got applied and manually error out if it did not.

I can't reproduce this.

If the YAML only contains this:

defaults:
  x86_64:
    machine: FOOBAR_I_DO_NOT_EXIST
    priority: 50

then products and scenarios are missing.

When I add them:

defaults:
  x86_64:
    machine: FOOBAR_I_DO_NOT_EXIST
    priority: 50
products: {}
scenarios: {}

And post this to a newly created job group:

./script/openqa-cli api -X POST --host http://localhost:9526 /job_templates_scheduling/85 schema=JobTemplates-01.yaml preview=0 template="$(cat /tmp/non-existing-machine.yaml)" -v

then it gets accepted, and I see no error and get a 200 OK.

But that is because there are no scenarios, so the machine is never checked.

When I post this:

defaults:
  i586:
    machine: FOOBAR_I_DO_NOT_EXIST
    priority: 50

products:
  opensuse-Tumbleweed-DVD-i586:
    distri: opensuse
    flavor: DVD
    version: Tumbleweed

scenarios:
  i586:
    opensuse-Tumbleweed-DVD-i586:
    - textmode:
        priority: 40

Then I get a 400 Bad Request:

{"error":["Machine 'FOOBAR_I_DO_NOT_EXIST' is invalid"],"error_status":400,"id":85,"job_group_id":85}

So there must be some difference in what you do.

We also have unit tests for this (see t/api/08-jobtemplates.t). Can you share the concrete API calls you're doing?

I completely forgot about this one and unfortunately don't have the setup anymore to reproduce this issue. So feel free to close it.