Project

General

Profile

action #93522

[tools][qem] auto-approval of kgrafts and live-patches

Added by hurhaj 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2021-06-07
Due date:
2021-08-06
% Done:

0%

Estimated time:

Description

kgraft / live-patch updates are tested exclusively in openQA, but are getting qam-kernel approval group. That means someone has to download, update and upload test reports that no one is ever reading. With around 60 at once, it's a waste of time. These updates could get qam-openqa group and (if green) be approved by bot based on results from their runs.

So we need:

  • switch the assigned group
  • configure bot to approve if all is good

History

#1 Updated by okurz 4 months ago

  • Subject changed from [qem] auto-approval of kgrafts and live-patches to [tools][qem] auto-approval of kgrafts and live-patches
  • Target version set to Ready

osukup this something that 1. you can do very quickly yourself or teach others how to do?

https://gitlab.suse.de/search?project_id=3530&search=kgraft shows some references but https://gitlab.suse.de/search?project_id=3530&search=qam-kernel does not reveal any hits. So where is this configured that qam-kernel is assigned? Or is this coming automatically from OBS/IBS because the kernel package is involved?

#2 Updated by osukup 4 months ago

groups are assigned by SMELT,

if kgraft has only qam-openqa group and is green it should be approved automaticaly

#3 Updated by okurz 4 months ago

right, so

  • configure bot to approve if all is good

is already covered.

So for

switch the assigned group

maybe changing
https://gitlab.suse.de/tools/smelt/-/blob/master/smelt/smeltapp/agents/assignrrs.yml#L494

is enough? hurhaj I guess you could try to apply that change yourself and ask smelt experts in a merge request if this is correct.

osukup if you agree then assign to hurhaj or whoever you think is better fitting.

#4 Updated by okurz 4 months ago

  • Status changed from New to In Progress

#5 Updated by openqa_review 4 months ago

  • Due date set to 2021-06-23

Setting due date based on mean cycle time of SUSE QE Tools

#6 Updated by osukup 4 months ago

  • Status changed from In Progress to Blocked

#7 Updated by okurz 4 months ago

https://gitlab.suse.de/tools/smelt/-/merge_requests/683 merged.

I assume we have to wait for a more recent smelt release than the current 3.9.4 : https://gitlab.suse.de/tools/smelt/-/releases

#8 Updated by cdywan 4 months ago

  • Due date changed from 2021-06-23 to 2021-07-02

osukup are we still waiting on a release? Can you clarify what this is blocking on?

#9 Updated by cdywan 3 months ago

  • Due date changed from 2021-07-02 to 2021-07-07

Moving due date due to public holidays

#10 Updated by okurz 3 months ago

  • Due date changed from 2021-07-07 to 2021-07-02

Same as in #91356#note-28 we should not fool ourselves by acting "surprised" that suddenly there is a public holiday :D That can not be the reason for having missed the deadline. Also you already bumped the deadline in before and there was no action.

#11 Updated by okurz 3 months ago

  • Status changed from Blocked to Resolved

We assume that this is fixed because there is a more recent release from smelt, the ticket description does not state how we could check if the original request is fulfilled. You are always welcome to tell us if something is missing.

#12 Updated by msmeissn 3 months ago

btw, this is probably ALSO affecting the real kernel updates ... not sure if you intended it this way.

(as real kernel updates have an initial livepatch)

#13 Updated by hurhaj 3 months ago

msmeissn wrote:

btw, this is probably ALSO affecting the real kernel updates ... not sure if you intended it this way.

(as real kernel updates have an initial livepatch)

no, it was not intended. and although it might be worthy of a discussion, definitely not like this.

osukup okurz could you readjust this? also, it will need SMELT update to fix this, correct?

#14 Updated by okurz 3 months ago

  • Due date changed from 2021-07-02 to 2021-08-06
  • Status changed from Resolved to Feedback

osukup can you please look into this and state if it's feasible to achieve? If the original benefit can not be achieved with side-effect I suggest to revert and plan differently for the future.

#15 Updated by osukup 3 months ago

(as real kernel updates have an initial livepatch)

no, it was not intended. and although it might be worthy of a discussion, definitely not like this.

and unfotuanetly LTSS updates have same product/repo for kernel and ltss --> so this is simple for full supported lp but not for LTSS lp without code changes in smelt.

#17 Updated by osukup 3 months ago

merged , so for now should be LP in own projects only with 'qam-openqa' and LTSS with 'qam-kernel' + 'qam-openqa'

#18 Updated by osukup 3 months ago

  • Status changed from Feedback to Resolved

unfortunately its solvable only for general supported LP, (which works ... as by complaints by some colleagues too much fast:))

Also available in: Atom PDF