QA » openQA Project

Observation¶

In https://discord.com/channels/366985425371398146/817367056956653621/837962685173071884 user "Amin" asked: "What is VIRSH_MAC?" related to an earlier question about using libvirt with openQA. I found a reference to VIRSH_MAC only in https://github.com/os-autoinst/os-autoinst/blob/a1b2e4bab594e1c37abab8045a8c3354ca1d03ce/doc/backends.md, nowhere else in os-autoinst code nor openQA nor the git histories of both repositories but we also reference VIRSH_MAC values in https://gitlab.suse.de/openqa/salt-pillars-openqa added by mgriessmeier in 2019.

Acceptance criteria¶

• AC1: VIRSH_MAC is only referenced in documentation in case it's actually used somewhere in the project where it's used/defined

Suggestions¶

• DONE: Crosscheck with mgriessmeier or other users what this value is intended for
• Delete references if not used Make sure this variable – and potentially other variables – are only referenced where defined or used, maybe it can be just moved to os-autoinst-distri-opensuse or the corresponding code can be moved to os-autoinst