Project

General

Profile

action #92046

os-autoinst file doc/backends.md references VIRSH_MAC which only applies to os-autoinst-distri-opensuse

Added by okurz 3 months ago. Updated 3 months ago.

Status:
Workable
Priority:
Low
Assignee:
-
Category:
Concrete Bugs
Target version:
Start date:
2021-05-01
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

In https://discord.com/channels/366985425371398146/817367056956653621/837962685173071884 user "Amin" asked: "What is VIRSH_MAC?" related to an earlier question about using libvirt with openQA. I found a reference to VIRSH_MAC only in https://github.com/os-autoinst/os-autoinst/blob/a1b2e4bab594e1c37abab8045a8c3354ca1d03ce/doc/backends.md, nowhere else in os-autoinst code nor openQA nor the git histories of both repositories but we also reference VIRSH_MAC values in https://gitlab.suse.de/openqa/salt-pillars-openqa added by mgriessmeier in 2019.

Acceptance criteria

  • AC1: VIRSH_MAC is only referenced in documentation in case it's actually used somewhere in the project where it's used/defined

Suggestions

  • DONE: Crosscheck with mgriessmeier or other users what this value is intended for
  • Delete references if not used Make sure this variable – and potentially other variables – are only referenced where defined or used, maybe it can be just moved to os-autoinst-distri-opensuse or the corresponding code can be moved to os-autoinst

History

#1 Updated by okurz 3 months ago

  • Subject changed from os-autoinst file doc/backends.md references VIRSH_MAC which seems to not be used anywhere to os-autoinst file doc/backends.md references VIRSH_MAC which only applies to os-autoinst-distri-opensuse
  • Description updated (diff)
  • Status changed from In Progress to Workable
  • Assignee deleted (okurz)
  • Target version changed from Ready to future

found it. It's read in os-autoinst-distri-opensuse, not os-autoinst. It's only used in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/64c984ce2d268733743431d74b7d8553b6d274a9/lib/bootloader_setup.pm#L1032 , within os-autoinst-distri-opensuse, the default test distribution used for openSUSE / SUSE Linux Enterprise . We hould clarify that this test variable and potentially others are not something that are actually needed within os-autoinst itself. But please be aware that there are likely no successful uses of the svirt backend outside os-autoinst-distri-opensuse so maybe in the current implementation it really only works together.

Also available in: Atom PDF