action #91658
closedQA - coordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release
coordination #89062: [epic] Simplify review for SUSE QAM
Make "black certificate" stricter to only show when /tests/overview?todo=1 is empty, i.e. no unlabeled failures
Description
Motivation¶
Acceptance criteria¶
- AC1: Same logic used to decide about todo=1 as well as the black certificate
Suggestions¶
- Check implementation of both todo=1 on /tests/overview as well as the black certificate icon
- Ensure that the black certificate only shows up when there are no unlabeled failures, not just plain comments, and then refactor to use the same code for "todo" or vice versa
Updated by mkittler over 3 years ago
Check implementation of both todo=1 on /tests/overview as well as the black certificate icon
TODO flag filters out all jobs
- not in state
done. - with result
passed. - with a bug reference or a label.
- with result
softfailedbut no failed modules.
The black certificate icon is shown when the number of comments is >= than the failed¹ jobs within a build. The code uses the term "labels" but it really just counts any kind of comment so far.
¹ "Failed" in the sense of the dashboard categorization: So "failed" means any job in the state done which hasn't passed/softfailed/aborted.
I suppose it would be sufficient to make the logic behind the certificate icon only consider comments with bug references and labels like the TODO flag. The behavior noted in remark ¹ is more or less in-line with the TODO flag but not exactly. However, I would refrain from adjusting the dashboard categorization here and would keep using it for the certificate icon as it belongs to the dashboard.
Updated by mkittler over 3 years ago
- Status changed from Workable to In Progress
Updated by openqa_review over 3 years ago
- Due date set to 2021-05-12
Setting due date based on mean cycle time of SUSE QE Tools
Updated by mkittler over 3 years ago
Additional PR: https://github.com/os-autoinst/openQA/pull/3872
Updated by mkittler over 3 years ago
- Status changed from In Progress to Feedback
The 2 PRs have been merged.
Updated by mkittler over 3 years ago
- Status changed from Feedback to Resolved
The first PR is actually already deployed and covers the AC.