Project

General

Profile

action #91658

QA - coordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release

coordination #89062: [epic] Simplify review for SUSE QAM

Make "black certificate" stricter to only show when /tests/overview?todo=1 is empty, i.e. no unlabeled failures

Added by okurz 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Feature requests
Target version:
Start date:
2021-04-23
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

#89062

Acceptance criteria

  • AC1: Same logic used to decide about todo=1 as well as the black certificate

Suggestions

  • Check implementation of both todo=1 on /tests/overview as well as the black certificate icon
  • Ensure that the black certificate only shows up when there are no unlabeled failures, not just plain comments, and then refactor to use the same code for "todo" or vice versa

History

#1 Updated by mkittler 3 months ago

  • Assignee set to mkittler

#2 Updated by mkittler 3 months ago

Check implementation of both todo=1 on /tests/overview as well as the black certificate icon

TODO flag filters out all jobs

  • not in state done.
  • with result passed.
  • with a bug reference or a label.
  • with result softfailed but no failed modules.

The black certificate icon is shown when the number of comments is >= than the failed¹ jobs within a build. The code uses the term "labels" but it really just counts any kind of comment so far.

¹ "Failed" in the sense of the dashboard categorization: So "failed" means any job in the state done which hasn't passed/softfailed/aborted.


I suppose it would be sufficient to make the logic behind the certificate icon only consider comments with bug references and labels like the TODO flag. The behavior noted in remark ¹ is more or less in-line with the TODO flag but not exactly. However, I would refrain from adjusting the dashboard categorization here and would keep using it for the certificate icon as it belongs to the dashboard.

#3 Updated by mkittler 3 months ago

  • Status changed from Workable to In Progress

#4 Updated by openqa_review 3 months ago

  • Due date set to 2021-05-12

Setting due date based on mean cycle time of SUSE QE Tools

#6 Updated by mkittler 3 months ago

  • Status changed from In Progress to Feedback

The 2 PRs have been merged.

#7 Updated by mkittler 3 months ago

  • Status changed from Feedback to Resolved

The first PR is actually already deployed and covers the AC.

#8 Updated by okurz 2 months ago

  • Due date deleted (2021-05-12)

Also available in: Atom PDF