Project

General

Profile

Actions

action #89206

closed

openqa-review CI failure about "ImportError: No module named enum" in python 2.7 tests

Added by okurz about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
Due date:
2021-03-18
% Done:

0%

Estimated time:

Description

Observation

from https://travis-ci.org/github/os-autoinst/openqa_review/builds/760568521?utm_source=github_status&utm_medium=notification

ImportError while importing test module '/home/travis/build/os-autoinst/openqa_review/tests/test_tumblesle_release.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_tumblesle_release.py:15: in <module>
    from openqa_review import tumblesle_release  # SUT
.tox/py27/lib/python2.7/site-packages/openqa_review/tumblesle_release.py:38: in <module>
    import pika
.tox/py27/lib/python2.7/site-packages/pika/__init__.py:10: in <module>
    from pika.connection import ConnectionParameters
.tox/py27/lib/python2.7/site-packages/pika/connection.py:15: in <module>
    import pika.callback
.tox/py27/lib/python2.7/site-packages/pika/callback.py:8: in <module>
    from pika import frame
.tox/py27/lib/python2.7/site-packages/pika/frame.py:7: in <module>
    from pika import spec
.tox/py27/lib/python2.7/site-packages/pika/spec.py:18: in <module>
    from pika.exchange_type import ExchangeType
.tox/py27/lib/python2.7/site-packages/pika/exchange_type.py:1: in <module>
    from enum import Enum
E   ImportError: No module named enum
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.58 seconds ============================

ERROR: InvocationError for command /home/travis/build/os-autoinst/openqa_review/.tox/py27/bin/py.test (exited with code 2)

Suggestion

  • Reproduce openqa_review build locally
  • Investigate breakage
  • Drop Python2 support (.travis.yml, tox.ini)
Actions #1

Updated by okurz about 3 years ago

  • Subject changed from openqa-review CI to openqa-review CI failure about "ImportError: No module named enum" in python 2.7 tests
Actions #2

Updated by mkittler about 3 years ago

Maybe we can simply cancel Python 2.x support at this point?

Actions #3

Updated by okurz about 3 years ago

Yes, you can. Just remove all references and maybe update the README or something

Actions #4

Updated by livdywan about 3 years ago

  • Description updated (diff)
  • Status changed from New to Workable
Actions #5

Updated by livdywan about 3 years ago

  • Status changed from Workable to In Progress
Actions #6

Updated by livdywan about 3 years ago

  • Assignee set to livdywan
Actions #7

Updated by openqa_review about 3 years ago

  • Due date set to 2021-03-18

Setting due date based on mean cycle time of SUSE QE Tools

Actions #8

Updated by livdywan about 3 years ago

cdywan wrote:

https://github.com/os-autoinst/openqa_review/pull/140

After looking into compat code I rebased the big commit, now it only has docs changes and tox/travis updates. That should be enough to fix this ticket.

Btw the python-openqa_review package has python2 bits, too. Not sure if that's actually built against python2 so that might be cosmetical.

Actions #9

Updated by livdywan about 3 years ago

  • Status changed from In Progress to Feedback

The PR got merged, hence setting this to Feedback. Might still look into open py2 aspects but will consider the bug described resolved.

Actions #10

Updated by okurz about 3 years ago

  • Status changed from Feedback to Resolved

https://travis-ci.org/github/os-autoinst/openqa_review/builds/762451862 shows the green build on master after the above PR. Thanks. Ticket resolved.

Actions

Also available in: Atom PDF