Project

General

Profile

Actions
Copy link

action #88317

closed

coordination #90086: [epic] Refactor container tests

When building a Dockerfile, specify variable FROM

Added by pdostal over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
ybonatakis
Target version:
-
Start date:
2021-01-28
Due date:
% Done:

80%

Estimated time:
Actions
Copy link
 #1

Updated by pdostal over 3 years ago

  • % Done changed from 0 to 80

Right now, there are two dockerfiles:

  • Dockerfile.suse using FROM $base
  • dockerfile.python3 using FROM python3

Those docker files are prepared in container_set_up() subroutine.
Then, in build_img() subroutine, the $registry/library/python:3 is pulled.
And finally, still in build_img() subroutine the docker file is built.

I think that the container_set_up() is OK and was done by @ybonatakis, but build_img() can still be improved.

Actions
Copy link
 #2

Updated by jlausuch about 3 years ago

  • Priority changed from Normal to Low
  • Parent task set to #90086
Actions
Copy link
 #3

Updated by pdostal about 3 years ago

pdostal wrote:

I think that the container_set_up() is OK and was done by @ybonatakis, but build_img() can still be improved.

Improved in a way that in build_img() we pull the image the Dockerfile is based on as it is not always python:3.

Actions
Copy link
 #4

Updated by jlausuch about 3 years ago

  • Status changed from New to Workable
Actions
Copy link
 #5

Updated by pdostal almost 3 years ago

  • Status changed from Workable to Resolved
  • Assignee changed from pdostal to ybonatakis

This has been done by Yiannis.

Actions
Copy link

Also available in: Atom PDF