Project

General

Profile

action #80576

[learning] perl warning in openqa-livehandler "Use of uninitialized value $ret in exit at /usr/share/openqa/script/openqa-livehandler line 31.", similar for openqa-websockets

Added by okurz 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
2020-11-29
Due date:
2020-12-16
% Done:

0%

Estimated time:
Difficulty:
easy

Description

Observation

Observed in system journal on o3:

Nov 29 03:00:21 ariel systemd[1]: Stopping Handler for live view in openQA's web UI...
Nov 29 03:00:21 ariel openqa-livehandler-daemon[2089]: Use of uninitialized value $ret in exit at /usr/share/openqa/script/openqa-livehandler line 31.
Nov 29 03:00:21 ariel openqa-livehandler-daemon[2089]: Web application available at http://127.0.0.1:9528
Nov 29 03:00:21 ariel openqa-livehandler-daemon[2089]: Web application available at http://[::1]:9528
Nov 29 03:00:21 ariel systemd[1]: Stopping The openQA web UI...
Nov 29 03:00:21 ariel systemd[1]: Stopping The openQA daemon for various background tasks like cleanup and saving needles...
Nov 29 03:00:21 ariel systemd[1]: Stopped Enqueues an audit event cleanup task for the openQA database every day..
Nov 29 03:00:21 ariel systemd[1]: Stopping Enqueues an audit event cleanup task for the openQA database every day..
Nov 29 03:00:21 ariel systemd[1]: Started Enqueues an audit event cleanup task for the openQA database every day..
Nov 29 03:00:21 ariel systemd[1]: Stopped Handler for live view in openQA's web UI.
Nov 29 03:00:21 ariel systemd[1]: Started Handler for live view in openQA's web UI.
Nov 29 03:00:21 ariel systemd[1]: Stopped The openQA web UI.
Nov 29 03:00:21 ariel systemd[1]: Stopped Enqueues an asset cleanup task for openQA every hour..
Nov 29 03:00:21 ariel systemd[1]: Stopping Enqueues an asset cleanup task for openQA every hour..
Nov 29 03:00:21 ariel systemd[1]: Started Enqueues an asset cleanup task for openQA every hour..
Nov 29 03:00:21 ariel systemd[1]: Stopping The openQA WebSockets server...
Nov 29 03:00:21 ariel systemd[1]: Stopped Enqueues a result/screenshots/logs cleanup task for openQA every day..
Nov 29 03:00:21 ariel systemd[1]: Stopping Enqueues a result/screenshots/logs cleanup task for openQA every day..
Nov 29 03:00:21 ariel systemd[1]: Started Enqueues a result/screenshots/logs cleanup task for openQA every day..
Nov 29 03:00:21 ariel systemd[1]: Stopped Enqueues a bug cleanup task for the openQA database every week..
Nov 29 03:00:21 ariel systemd[1]: Stopping Enqueues a bug cleanup task for the openQA database every week..
Nov 29 03:00:21 ariel systemd[1]: Started Enqueues a bug cleanup task for the openQA database every week..
Nov 29 03:00:21 ariel openqa-websockets-daemon[2092]: Use of uninitialized value $ret in exit at /usr/share/openqa/script/openqa-websockets line 31.
Nov 29 03:00:21 ariel openqa-websockets-daemon[2092]: Web application available at http://127.0.0.1:9527
Nov 29 03:00:21 ariel openqa-websockets-daemon[2092]: Web application available at http://[::1]:9527
Nov 29 03:00:21 ariel systemd[1]: Stopped The openQA WebSockets server.
Nov 29 03:00:21 ariel systemd[1]: Stopping The openQA Scheduler...
Nov 29 03:00:21 ariel openqa-scheduler-daemon[2091]: Web application available at http://127.0.0.1:9529
Nov 29 03:00:21 ariel openqa-scheduler-daemon[2091]: Web application available at http://[::1]:9529
Nov 29 03:00:21 ariel systemd[1]: Stopped The openQA Scheduler.
Nov 29 03:00:21 ariel systemd[1]: Started The openQA Scheduler.
Nov 29 03:00:21 ariel systemd[1]: Started The openQA WebSockets server.
Nov 29 03:00:21 ariel systemd[1]: Started The openQA web UI.

Expected result

No perl warning about uninitialized value

Suggestions

Look into script/openqa-websockets line 31 and script/openqa-livehandler line 31. Maybe we can simply define a sensible default

History

#1 Updated by mkittler 8 months ago

  • Assignee set to mkittler

#2 Updated by mkittler 8 months ago

This is a regression from https://github.com/os-autoinst/openQA/commit/a2d64957501cd7e727d2b4bf9e23e727ef71d21f which was trying to improve the handling when an invalid argument is specified. I'm fixing the regression with https://github.com/os-autoinst/openQA/pull/3605 but that's partially reverting the initial commit. However, kraih also made an upstream Mojolicious commit to tackle the case the initial commit tried to fix correctly.

#3 Updated by mkittler 8 months ago

  • Status changed from Workable to In Progress

#4 Updated by openqa_review 8 months ago

  • Due date set to 2020-12-16

Setting due date based on mean cycle time of SUSE QE Tools

#5 Updated by mkittler 8 months ago

  • Status changed from In Progress to Resolved

PR has been merged

Also available in: Atom PDF