Project

General

Profile

action #77014

openQA webui entry "Assigned worker" shows ip instead of names as formerly

Added by okurz 9 months ago. Updated 8 months ago.

Status:
Workable
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
Start date:
2020-11-05
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

For example https://openqa.opensuse.org/tests/1459575# shows "Assigned worker: 192.168.112.7:4" whereas previously we had the hostname. https://github.com/os-autoinst/openQA/pull/3481 has changed the behaviour.

Acceptance criteria

  • AC1: the webUI shows hostnames, not IPv4 addresses

Suggestions

Maybe we can use the hostname. This should be tested, ini file examples should be updated and done at least on o3 as well


Related issues

Related to openQA Infrastructure - action #77209: workers on o3 machine rebel provide no "WORKER_HOSTNAME" value anymore but it shows up in journal of worker serviceResolved2020-11-09

Copied to openQA Infrastructure - action #78438: openQA webui entry "Assigned worker" shows ip instead of names as formerly - manual cleanup workResolved2020-11-05

History

#1 Updated by okurz 9 months ago

  • Status changed from New to Feedback
  • Assignee set to okurz
  • Priority changed from Low to High
  • Target version changed from future to Ready

this has been raised as a problem by another user, so it's not just me.

I propose a revert for now with https://github.com/os-autoinst/openQA/pull/3520

#2 Updated by okurz 9 months ago

DimStar mentioned this problem as well in IRC, merged.

For this ticket: Implement test covering the observations from regression.

For retrospective: Discuss changes done without tickets as been done for the original PR https://github.com/os-autoinst/openQA/pull/3481 . While not necessarily bad we could have still benefit to discuss the idea and potential caveats further and keep the ticket to check ourselves for verification in production and record user feedback.

#3 Updated by okurz 9 months ago

  • Related to action #77209: workers on o3 machine rebel provide no "WORKER_HOSTNAME" value anymore but it shows up in journal of worker service added

#4 Updated by okurz 9 months ago

  • Status changed from Feedback to Workable
  • Assignee deleted (okurz)
  • Priority changed from High to Low

revert merged and deployed on o3. Not yet on osd though.

I guess next step would be to try to set real hostnames in our infrastructure and bring back https://github.com/os-autoinst/openQA/commit/1786e30b528cb888fa49474d39cd25b80415d629 but carefully check that where expected only hostnames show up, e.g. webUI on worker page, assigned worker in job details, development mode still works, https://stats.openqa-monitor.qa.suse.de/d/nRDab3Jiz/openqa-jobs-test?orgId=1&fullscreen&panelId=10 shows worker hostnames, etc.

#5 Updated by okurz 8 months ago

  • Target version changed from Ready to future

The original change would be nice to have again but since we have it reverted we can also plan to do this later, not now, hence "future".

#6 Updated by mkittler 8 months ago

Wasn't the point of the previous PR to show this on the web UI page (without being aware that this means using the IP in production)?

#7 Updated by okurz 8 months ago

mkittler wrote:

Wasn't the point of the previous PR to show this on the web UI page (without being aware that this means using the IP in production)?

I'm sorry, what PR do you mean with "previous" and what means "show this"? :)

#8 Updated by mkittler 8 months ago

Let me rephrase: Wasn't the point of https://github.com/os-autoinst/openQA/pull/3481 to show the hostname as specified in workers.ini? When I would have been aware that we specify an IP address there in production I wouldn't have accepted the PR in the first place.

#9 Updated by okurz 8 months ago

Yes, showing the hostname as specified in workers.ini was the point of https://github.com/os-autoinst/openQA/pull/3481 and yes, we would not have accepted the PR if we knew that we use IPv4 addressed and that would be shown in webUI :)

So what I would prefer is to bring back https://github.com/os-autoinst/openQA/pull/3481 , maybe in a changed form, use hostnames in workers.ini so that we leave the choice to the OS if IPv4 or IPv6 is used and then show that nice hostname in the webUI as well, at best together with an option to override the name in workers.ini as well

#10 Updated by okurz 8 months ago

  • Copied to action #78438: openQA webui entry "Assigned worker" shows ip instead of names as formerly - manual cleanup work added

Also available in: Atom PDF