action #72130
open
[easy][beginner] check and/or reduce runtime of t/api/04-jobs.t
Added by okurz over 3 years ago.
Updated about 2 years ago.
Category:
Feature requests
Description
Observation¶
https://app.circleci.com/pipelines/github/os-autoinst/openQA/4393/workflows/73728ebb-2783-487d-bf09-79f3ee2270ef/jobs/42262 shows
[06:58:59] t/api/04-jobs.t .................... 27/? Bailout called. Further testing stopped: test exceeds runtime limit of '120' seconds
FAILED--Further testing stopped: test exceeds runtime limit of '120' seconds
Acceptance criteria¶
- AC1: t/api/04-jobs.t internal timeout is significantly lower than currently, e.g. 20s
Suggestions¶
- Profile runtime of test and identify points for improvement
- Optimize test, potentially split
- Reduce timeout in test module
Further details¶
entrance level issue
- Copied from action #72127: check and/or reduce runtime of t/44-scripts.t added
- Status changed from In Progress to Feedback
- Description updated (diff)
- Category changed from Regressions/Crashes to Feature requests
- Status changed from Feedback to Workable
- Assignee deleted (
okurz)
- Priority changed from High to Low
PR is merged. With this the timeout limit should be more stable. Updated ticket to describe next tasks in detail, i.e. optimize test module
- Status changed from Workable to In Progress
- Assignee set to mkittler
- Status changed from In Progress to Workable
- Assignee deleted (
mkittler)
After your PR the time limit is at 30 seconds which seems good considering the test needs a little bit more than 20 seconds.
I wouldn't split the test because that just adds more database initialization overhead. There are no points where this test "hangs" waiting for something. As such I couldn't find much room for optimization and I wouldn't rework the entire test just so squeeze a few seconds out of it.
- Target version changed from Ready to future
Thank you for looking into this. I think you have not conducted a profiling run though and I consider 20s of runtime for a local non-UI test rather long still. Also, the test module is 1.3k lines long so also not that easily maintainable. Splitting is not the only option but still we could move out the "extra test" parsing test parts into a separate test module. I consider it more common for developers to run individual test modules and leave the complete test set to CI runs by default.
Nevertheless it is ok if we come back to this some time later, not now :)
- Tags set to easy, beginner, entrance level
- Subject changed from check and/or reduce runtime of t/api/04-jobs.t to [easy][beginner] check and/or reduce runtime of t/api/04-jobs.t
- Description updated (diff)
Also available in: Atom
PDF