Project

General

Profile

action #71896

[y] Expert partitioning framework refactoring

Added by ybonatakis 7 months ago. Updated 6 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
2020-09-25
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

As we are expanding and adding new subroutines in the framework we need to consider some refactoring to avoid duplication and make it more usable.

Things to refactor:

  • _set_partitioning subroutine
  • this does not work for all the partitioning options
  • _encrypt_with_lvm subroutine
  • The encryption should work for a higher level for all the Pages that implement encryption
  • select_item_in_system_view_table subroutine
  • replace if-else with state design or find another solution.
  • Consider expansion?
  • naming of the Pages
  • The pages use the name of the page that they access but it is hard to tell if which proposal(current or suggested) comes from

Let start with small things because more can come up but design is something that need to be always a task in progress but we cant cover everything.

History

#1 Updated by ybonatakis 6 months ago

10528

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/11037 does not resolve the duplication issue with the pages.
Similar Pages with different names can be subclassed by another higher class to avoid duplicattion
an example
Similar frames in yast

#2 Updated by riafarov 6 months ago

  • Status changed from New to Rejected
  • Assignee set to riafarov

Rejecting as we are going to use REST API with libyui here instead of further development of the partitioning functionality.

Also available in: Atom PDF