Actions
action #70612
openbetter error handling in testapi function script_output (was: script_output() ignores parse errors)
Status:
New
Priority:
Normal
Assignee:
-
Category:
Feature requests
Target version:
QA (public, currently private due to #173521) - future
Start date:
2020-08-27
Due date:
% Done:
0%
Estimated time:
Description
Motivation¶
I've just spent 2 hours staring into code trying to figure out why get_patches() in lib/qam.pm rejected an update that has the right incident ID and is marker as needed.
https://openqa.suse.de/tests/4596773#step/update_kernel/63
Then I've noticed that the leading output marker is malformed due to VNC typing issue so script_output() simply returned an empty string to get_patches().
When script_output() fails to parse the output, it shouldn't silently return an empty string. Suggestion: It should throw an exception.
Acceptance criteria¶
- AC1: Parsing errors in script_output can be easily distinguished from a false boolean result from the internal called script command
Suggestions¶
- Review and potentially extend os-autoinst t/03-testapi.t for how script_output behaves on an error like lost characters leading to unparseable responses
Actions