action #69484
closedperl warning in os-autoinst t/99-full-stack.t "Subroutine OpenQA::Isotovideo::Utils::diag redefined at …os-autoinst/t/data/tests/main.pm line 19." not caught
Description
Observation¶
Calling prove -I. -v t/99-full-stack.t yields
t/99-full-stack.t ..
# data dir: /home/okurz/local/os-autoinst/os-autoinst/t/data/
# pool dir: /tmp/99-full-stack.t-9bcO/pool/
[2020-07-31T12:08:29.269 CEST] [debug] Current version is 4a6de446ae59b7a8af7d2bdecf0279eb7b7a366d [interface v20]
[2020-07-31T12:08:29.279 CEST] [debug] git hash in /home/okurz/local/os-autoinst/os-autoinst/t/data//tests: 4a6de446ae59b7a8af7d2bdecf0279eb7b7a366d
Subroutine OpenQA::Isotovideo::Utils::diag redefined at /home/okurz/local/os-autoinst/os-autoinst/t/data/tests/main.pm line 19.
the last line, a perl warning, should stop the test from executing and fail due to our use of "Test::Warnings" but probably that does not work as we spawn isotovideo in a subprocess
Acceptance criteria¶
- AC1: perl warnings during test execution fail tests
Suggestions¶
Maybe we can apply Test::Warnings for the subprocess or we handle that with #10704
Updated by okurz over 4 years ago
- Status changed from Workable to Feedback
- Assignee set to okurz
- Target version changed from future to Ready
https://github.com/os-autoinst/os-autoinst/pull/1496 to address the specific warning. https://github.com/os-autoinst/os-autoinst/pull/1497 with a new feature to handle any Perl warning even within test distributions as fatal.
Updated by livdywan over 4 years ago
Are you still planning to work on this? Or is #10704 the way forward?
Updated by okurz over 4 years ago
- Status changed from Feedback to Resolved
well, I guess keeping #10704 open where I also linked https://github.com/os-autoinst/os-autoinst/pull/1497 is good enough as the actual original error reported about here is fixed.