action #68579
closed
[y] gitlab-ci needs another stage for verify_file_existence
Added by ybonatakis almost 4 years ago.
Updated over 3 years ago.
Description
We used to create new files in new PR. We usually have a test PR open while we create a MR to the qa-sle-functional-y. And this makes the test pipeline to fail. Which it should not.
There are many solutions.
My propose is to create another stage in pipeline which will suit our logic.
Files
- Subject changed from [y] gitlab-ci needs another pipeline for verify_file_existence to [y] gitlab-ci needs another stage for verify_file_existence
- Target version set to future
I would say this is an overkill, re-triggerind pipeline after PR is merged is the best thing, as if you assume that PR will get merged, there is no guarantee that this will happen before MR (PR denotes github, MR denotes gitlab). So tbh, I would reject this item. Pipeline should fail in the described case.
The only rational I can suggest from the description that we re-trigger pipeline automatically in some way, but that won't be easy.
https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/merge_requests/231.
Another solution that will make the test stage run against the associate test repository.
the commit i provide needs some improvements as to work properly needs two basic variables, github username and branch name. i used $GITLAB_USER_LOGIN which will work in case the username is the same between gitlab and github accounts. $CI_COMMIT_TITLE is not in any use as it is. But i thought that i could reuse this and get from there the branch name.
I will take a look in the upcoming week.
- Project changed from openQA Tests to qe-yam
- Status changed from New to Rejected
- Assignee changed from ybonatakis to riafarov
Idea was not clear and we didn't find why would we need separate stage.
Also available in: Atom
PDF
