Project

General

Profile

action #68413

De-duplicate definitions of needle soft-fail markers (was: screenshot shows soft-fail border for a needle with bug reference but the module turns out to be "passed", expected "softfailed")

Added by okurz 20 days ago. Updated 8 days ago.

Status:
Workable
Priority:
Normal
Assignee:
-
Category:
Concrete Bugs
Target version:
Start date:
2020-06-24
Due date:
% Done:

0%

Estimated time:
Difficulty:
Duration:

Description

Observation

see https://openqa.opensuse.org/tests/1306944#step/wine/26

Reproducible

Reproduced, e.g. in the same scenario in other jobs the same

Expected result

The softfailed needle should make the module result turn "softfailed" as well

Problem

Likely a regression that was introduced within the last year with some changes regarding the handling of softfails

Further details

Always latest result in this scenario: latest

History

#1 Updated by okurz 20 days ago

  • Project changed from openQA Tests to openQA Project
  • Category changed from Bugs in existing tests to Concrete Bugs
  • Status changed from New to Workable
  • Assignee set to Xiaojing_liu
  • Target version set to Ready

@Xiaojing_liu can you please read the ticket and state if you can explain what is happening here? Could this be related to work done by you some months ago about handling of softfailed/workaround needles?

#2 Updated by Xiaojing_liu 17 days ago

  • Status changed from Workable to In Progress

I check this issue, it is related to the pr that I worked some months ago. I did not consider the needle file contained boo.
Made a pull request to fix this: https://github.com/os-autoinst/os-autoinst/pull/1450

#3 Updated by okurz 14 days ago

The PR is merged however I think the reason why we have this problem in the first place was os-autoinst commit ed3da7cc that introduced the regex /\S+\-(bsc|poo|bnc)(\d+)\-\S+/ within os-autoinst which we already have in openQA. We should try to find a way that we only have one place for the definition. E.g. we should be able to move the corresponding code from openQA to os-autoinst and just use it from there.

#4 Updated by Xiaojing_liu 9 days ago

okurz wrote:

The PR is merged however I think the reason why we have this problem in the first place was os-autoinst commit ed3da7cc that introduced the regex /\S+\-(bsc|poo|bnc)(\d+)\-\S+/ within os-autoinst which we already have in openQA. We should try to find a way that we only have one place for the definition. E.g. we should be able to move the corresponding code from openQA to os-autoinst and just use it from there.

I could not find a way to define this in one place. Both os-autoinst and openQA need to parse the needle file name.

#5 Updated by Xiaojing_liu 8 days ago

  • Status changed from In Progress to Feedback
  • Assignee deleted (Xiaojing_liu)

I did not find a way to improve the code, so I delete the Assignee and set it to Feedback.

#6 Updated by okurz 8 days ago

  • Subject changed from screenshot shows soft-fail border for a needle with bug reference but the module turns out to be "passed", expected "softfailed" to De-duplicate definitions of needle soft-fail markers (was: screenshot shows soft-fail border for a needle with bug reference but the module turns out to be "passed", expected "softfailed")
  • Status changed from Feedback to Workable

Ok, clear. Let's still try to use this ticket to address this issue

Also available in: Atom PDF