Project

General

Profile

Actions
Copy link

action #67534

closed

[functional][y] Change yast2_lan hostname validation

Added by syrianidou_sofia almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
ybonatakis
Category:
Enhancement to existing tests
Target version:
SUSE QA - SLE 15 SP2
Start date:
2020-06-01
Due date:
2020-06-30
% Done:

0%

Estimated time:
5.00 h
Difficulty:

Description

In yast2_lan module, one of the steps is to verify that the hostname can be successfully changed. Currently in the code, the hostname used for the change comes from: $hostname = get_var('HOSTNAME', 'susetest') . For most architectures 'susetest' is also the hostname prior the change. So, in reality it doesn't verify if the hostname was changed ( https://openqa.suse.de/tests/4286250#step/yast2_lan/13 ).

On some backends we cannot change hostname without breaking the setup (at least powerVM and zVM). So we might need to limit scope of test to qemu.

Running the module on xen hvm, where original hostname is not 'susetest', fails (https://openqa.suse.de/tests/4295089#step/yast2_lan/20).
Running the module on x86, with different $hostname works (new needle needed for that to work) (http://falafel.suse.cz/tests/832#step/yast2_lan/23).

Acceptance criteria:

  • Change the code of yast2_lan so that the hostname after change is different than before.
Actions
Copy link
 #1

Updated by syrianidou_sofia almost 4 years ago

Opened ticket https://progress.opensuse.org/issues/67537 for Xen issue

Actions
Copy link
 #2

Updated by riafarov almost 4 years ago

  • Due date set to 2020-06-30
  • Category set to Enhancement to existing tests
  • Target version set to SLE 15 SP2
Actions
Copy link
 #3

Updated by riafarov almost 4 years ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Estimated time set to 5.00 h
Actions
Copy link
 #4

Updated by ybonatakis almost 4 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions
Copy link
 #5

Updated by ybonatakis almost 4 years ago

  • Status changed from In Progress to Feedback

I am about to set this as rejected as i cant see any problem, or reproduce the error above.

I run https://openqa.suse.de/tests/overview?distri=sle&build=b10n1k%2Fos-autoinst-distri-opensuse%23lan_test&version=15-SP2 using HOSTNAME=iob. In such cases, we have just to create a new needle to make the tests work. i think the problem above came from some misuse of the code and not use of the HOSTNAME variable

Is something else that i am missing here? or should i close this ticket

Actions
Copy link
 #6

Updated by ybonatakis almost 4 years ago

  • Status changed from Feedback to Resolved

The module is fine. To validate that the hostname is able to change there is validation with the
check_etc_hosts_update() in L83. This does not run in our job because it needs to set VALIDATE_ETC_HOSTS variable in the settings.

For xen the problem is different as it described here. But briefly, it is not problem of the module but how the bridged network set the hostname in those machine, making use always the external hostname

Actions
Copy link

Also available in: Atom PDF