Project

General

Profile

Actions
Copy link

action #65933

closed

Add --help to all our scripts

Added by tinita over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Low
Assignee:
okurz
Category:
Feature requests
Target version:
QA (public) - future
Start date:
2020-04-21
Due date:
% Done:

0%

Estimated time:

Description

There are several scripts in the script/ directory which can't be called with --help.

This makes it impossible to quickly check what the scripts are doing.

I added a test t/44-scripts.t which calls all scripts with --help, and the following scripts still don't have that option, or fail in CI with that option:

  • check_dependencies
  • openqa-workercache
  • openqa (has help output, but fails in CI)
  • openqa-livehandler (has help output, but fails in CI)

Still to check:

  • script/configure-web-proxy
  • script/fetchneedles
  • script/openqa-bootstrap
  • script/openqa-bootstrap-container
  • script/openqa-clone-custom-git-refspec
  • script/openqa-enqueue-asset-cleanup
  • script/openqa-enqueue-audit-event-cleanup
  • script/openqa-enqueue-bug-cleanup
  • script/openqa-enqueue-result-cleanup
  • script/setup-db

Related issues 1 (0 open — 1 closed)

Related to openQA Project (public) - action #68167: [tests][services] Tests for systemd services and/or the daemon wrapper scripts and wrong arguments should exit services with failureResolvedokurz2020-06-172020-10-23

Actions
Actions
Copy link
 #1

Updated by okurz over 4 years ago

  • Priority changed from Normal to Low
Actions
Copy link
 #3

Updated by okurz over 4 years ago

  • Status changed from New to Feedback
  • Assignee set to okurz

Thanks, haven't looked hard enough for this ticket ;)

Actions
Copy link
 #4

Updated by okurz over 4 years ago

https://github.com/os-autoinst/openQA/pull/2994 was merged. We can still try to add a help option to more scripts, especially after I add some wrapper script in https://github.com/os-autoinst/openQA/pull/3012 . Let's wait for that one first.

Actions
Copy link
 #5

Updated by okurz over 4 years ago

  • Status changed from Feedback to Resolved

https://github.com/os-autoinst/openQA/pull/3012 merged. Now I have created https://github.com/os-autoinst/openQA/pull/3075 to provide also help to "script/configure-web-proxy", merely as experiment. I consider this ticket done because the TODOs as originally described are all solved now.

Actions
Copy link
 #6

Updated by okurz over 4 years ago

  • Status changed from Resolved to Feedback

Actually I have an idea for a low-effort approach, added in https://github.com/os-autoinst/openQA/pull/3075

Actions
Copy link
 #7

Updated by okurz over 4 years ago

  • Status changed from Feedback to Resolved

merged. Good enough :)

Actions
Copy link
 #8

Updated by okurz about 4 years ago

  • Related to action #68167: [tests][services] Tests for systemd services and/or the daemon wrapper scripts and wrong arguments should exit services with failure added
Actions
Copy link

Also available in: Atom PDF