action #65933
closedAdd --help to all our scripts
0%
Description
There are several scripts in the script/
directory which can't be called with --help
.
This makes it impossible to quickly check what the scripts are doing.
I added a test t/44-scripts.t
which calls all scripts with --help
, and the following scripts still don't have that option, or fail in CI with that option:
- check_dependencies
- openqa-workercache
- openqa (has help output, but fails in CI)
- openqa-livehandler (has help output, but fails in CI)
Still to check:
- script/configure-web-proxy
- script/fetchneedles
- script/openqa-bootstrap
- script/openqa-bootstrap-container
- script/openqa-clone-custom-git-refspec
- script/openqa-enqueue-asset-cleanup
- script/openqa-enqueue-audit-event-cleanup
- script/openqa-enqueue-bug-cleanup
- script/openqa-enqueue-result-cleanup
- script/setup-db
Updated by livdywan over 4 years ago
Updated by okurz over 4 years ago
- Status changed from New to Feedback
- Assignee set to okurz
Thanks, haven't looked hard enough for this ticket ;)
Updated by okurz over 4 years ago
https://github.com/os-autoinst/openQA/pull/2994 was merged. We can still try to add a help option to more scripts, especially after I add some wrapper script in https://github.com/os-autoinst/openQA/pull/3012 . Let's wait for that one first.
Updated by okurz over 4 years ago
- Status changed from Feedback to Resolved
https://github.com/os-autoinst/openQA/pull/3012 merged. Now I have created https://github.com/os-autoinst/openQA/pull/3075 to provide also help to "script/configure-web-proxy", merely as experiment. I consider this ticket done because the TODOs as originally described are all solved now.
Updated by okurz over 4 years ago
- Status changed from Resolved to Feedback
Actually I have an idea for a low-effort approach, added in https://github.com/os-autoinst/openQA/pull/3075
Updated by okurz about 4 years ago
- Related to action #68167: [tests][services] Tests for systemd services and/or the daemon wrapper scripts and wrong arguments should exit services with failure added