Project

General

Profile

action #68167

[tests][services] Tests for systemd services and/or the daemon wrapper scripts and wrong arguments should exit services with failure

Added by okurz about 1 year ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2020-06-17
Due date:
2020-10-23
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

See regression discussed in #68164

Acceptance criteria

  • AC1: Tests exists for systemd services executed in every pull request
  • AC2: Prevent wrong arguments exiting the service with success

Suggestions

  • We already put most of the logic into wrapper scripts so maybe we can just get along without testing systemd at all but we need tests for the wrapper scripts. Try out how the tests can be tested, e.g. very simple high-level tests that services start up correctly when using these scripts.
  • Research how to best test systemd service in our test setup, if at all

Related issues

Related to openQA Project - action #65933: Add --help to all our scriptsResolved2020-04-21

History

#1 Updated by okurz 12 months ago

  • Subject changed from Tests for systemd services and/or the daemon wrapper scripts and wrong arguments should exit services with failure to [tests][services] Tests for systemd services and/or the daemon wrapper scripts and wrong arguments should exit services with failure

#2 Updated by okurz 10 months ago

#3 Updated by okurz 10 months ago

  • Due date set to 2020-10-09
  • Status changed from Workable to Feedback
  • Assignee set to okurz

#4 Updated by okurz 10 months ago

  • Due date changed from 2020-10-09 to 2020-10-23

I had created https://github.com/os-autoinst/openQA/pull/3440 to add tests for shell scripts. In https://github.com/os-autoinst/openQA/pull/3441#issuecomment-706010354 first I am asking what we expect from upstream mojo behaviour.

#5 Updated by okurz 9 months ago

  • Status changed from Feedback to Resolved

upstream mojo does the same now in https://github.com/mojolicious/mojo/commit/82efa95bbe28a69df57e16ffe3232e3ab8b3f766 . Then I waited until we had the new package and https://github.com/os-autoinst/openQA/pull/3441 turned green \o/ … and we merged.

Also available in: Atom PDF