Project

General

Profile

Actions
Copy link

action #6344

closed

Add hidden flag to JobSettings to prevent privacy leak

Added by oholecek about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
oholecek
Category:
Regressions/Crashes
Target version:
Sprint 15
Start date:
2015-02-20
Due date:
% Done:

100%

Estimated time:

Description

  • add hidden column to JobSettings table
  • prevent displaying hidden rows
Actions
Copy link
 #1

Updated by lnussel about 9 years ago

https://github.com/os-autoinst/openQA/pull/188#issuecomment-75239152

just move the private setting to worker settings

Actions
Copy link
 #2

Updated by coolo about 9 years ago

  • Assignee set to oholecek
  • Target version changed from Sprint 14 to Sprint 15
Actions
Copy link
 #3

Updated by ancorgs about 9 years ago

Cannot this be a symptom that we are abusing the JobSetting concept by using it to store the auth token?

Actions
Copy link
 #4

Updated by coolo about 9 years ago

Well, generally there shouldn't be anything in the job settings that is not a setting - in that sense we're abusing it, yes. As such moving to WorkerProperties sounds like a good move.

Actions
Copy link
 #5

Updated by oholecek about 9 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by oholecek about 9 years ago

https://github.com/os-autoinst/openQA/pull/213

JobToken stored as Worker property now

Actions
Copy link
 #7

Updated by oholecek about 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF