action #61143: Show asset table also when cleanup is ongoing - openQA Project - openSUSE Project Management Tool

Actions

Copy link

action #61143

closed

Show asset table also when cleanup is ongoing

Added by mkittler over 4 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

mkittler

Category:

Feature requests

Target version:

Done

Start date:

2019-12-18

Due date:

% Done:

Estimated time:

Description

So far the message "Unable to request asset status: Asset cleanup is currently ongoing." is displayed when accessing /admin/assets while cleanup is ongoing. When the asset statistics have already been cached from a previous cleanup run we could easily show that cached data (it wouldn't be inconsistent). We could still keep "Asset cleanup is currently ongoing." as an information.

Actions

Copy link

Updated by coolo over 4 years ago

it would be consistent but possibly outdated - so I wonder if you can make the warning big enough not to get annoying bug reports :)

Actions

Copy link

Updated by mkittler about 4 years ago

Status changed from New to In Progress
Assignee set to mkittler
Target version changed from future to Current Sprint

I've been adding the issue to the current sprint because I'm too often annoyed by this and it shouldn't be hard to implement: https://github.com/os-autoinst/openQA/pull/2677

There's already a "last updated: ..." within the heading of the page. That is because the data has not been live since I had introduced the caching. (Displaying live data was just very slow. It is still possible to view live data using the force_refresh parameter and that won't change.)

Actions

Copy link

Updated by okurz about 4 years ago

PR was merged. Tests failed in OBS afterwards, e.g. https://build.opensuse.org/public/build/devel:openQA/openSUSE_Tumbleweed/x86_64/openQA/_log shows

[  490s] #   Failed test 'asset status rendered from cache file although cleanup is ongoing'
[  490s] #   at ./t/15-assets.t line 272.
[  490s] #          got: '400'
[  490s] #     expected: '200'
[  490s] 
[  490s] #   Failed test 'cache file removed'
[  490s] #   at ./t/15-assets.t line 273.
[  490s] # Looks like you failed 2 tests of 46.
[  490s] ./t/15-assets.t ..................................

Actions

Copy link