action #61143

Show asset table also when cleanup is ongoing

Added by mkittler 2 months ago. Updated about 1 month ago.

Status:ResolvedStart date:18/12/2019
Priority:NormalDue date:
Assignee:mkittler% Done:

0%

Category:Feature requests
Target version:Done
Difficulty:
Duration:

Description

So far the message "Unable to request asset status: Asset cleanup is currently ongoing." is displayed when accessing /admin/assets while cleanup is ongoing. When the asset statistics have already been cached from a previous cleanup run we could easily show that cached data (it wouldn't be inconsistent). We could still keep "Asset cleanup is currently ongoing." as an information.

History

#1 Updated by coolo 2 months ago

it would be consistent but possibly outdated - so I wonder if you can make the warning big enough not to get annoying bug reports :)

#2 Updated by mkittler about 1 month ago

  • Status changed from New to In Progress
  • Assignee set to mkittler
  • Target version changed from future to Current Sprint

I've been adding the issue to the current sprint because I'm too often annoyed by this and it shouldn't be hard to implement: https://github.com/os-autoinst/openQA/pull/2677

There's already a "last updated: ..." within the heading of the page. That is because the data has not been live since I had introduced the caching. (Displaying live data was just very slow. It is still possible to view live data using the force_refresh parameter and that won't change.)

#3 Updated by okurz about 1 month ago

PR was merged. Tests failed in OBS afterwards, e.g. https://build.opensuse.org/public/build/devel:openQA/openSUSE_Tumbleweed/x86_64/openQA/_log shows

[  490s] #   Failed test 'asset status rendered from cache file although cleanup is ongoing'
[  490s] #   at ./t/15-assets.t line 272.
[  490s] #          got: '400'
[  490s] #     expected: '200'
[  490s] 
[  490s] #   Failed test 'cache file removed'
[  490s] #   at ./t/15-assets.t line 273.
[  490s] # Looks like you failed 2 tests of 46.
[  490s] ./t/15-assets.t .................................. 

#4 Updated by mkittler about 1 month ago

  • Status changed from In Progress to Feedback

#5 Updated by mkittler about 1 month ago

  • Status changed from Feedback to Resolved
  • Target version changed from Current Sprint to Done

works on o3

Also available in: Atom PDF